From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9390C6E3BA for ; Wed, 9 Jan 2019 18:04:40 +0000 (UTC) References: <20190109174057.16835-1-lukasz.kalamarz@intel.com> <20190109174057.16835-2-lukasz.kalamarz@intel.com> From: Daniele Ceraolo Spurio Message-ID: <83d0801a-6fd0-1e45-d70b-3594aad5cc08@intel.com> Date: Wed, 9 Jan 2019 10:04:39 -0800 MIME-Version: 1.0 In-Reply-To: <20190109174057.16835-2-lukasz.kalamarz@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 2/6] lib/ioctl_wrapper: Implement __gem_mmap List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lukasz Kalamarz , igt-dev@lists.freedesktop.org List-ID: CgpPbiAwMS8wOS8yMDE5IDA5OjQwIEFNLCBMdWthc3ogS2FsYW1hcnogd3JvdGU6Cj4gUHJldmlv dXMgaW1wbGVtZW50YXRpb24gb2YgX19nZW1fbW1hcF9fY3B1IGFuZCBfX2dlbV9tbWFwX3djICBv bmx5Cj4gZGlmZmVyIHdpdGggc2V0dGluZyBwcm9wZXIgZmxhZyBmb3IgY2FjaGluZy4gVGhpcyBw YXRjaCBpbXBsZW1lbnQgX19nZW1fbW1hcAo+IHdoaWNoIG1lcmdlIHRob3NlIHR3byBmdW5jdGlv bnMgaW50byBvbmUgd3JhcHBlci4KPiBTbWFsbCBkb2N1bWVudGF0aW9uIG1vZGlmaWNhdGlvbiBh cmUgYWRkIHRvIGJlIGluIHBhciB3aXRoIG5ldyBpbXBsZW1lbnRhdGlvbi4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBMdWthc3ogS2FsYW1hcnogPGx1a2Fzei5rYWxhbWFyekBpbnRlbC5jb20+Cj4gQ2M6 IE1pY2hhbCBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tPgo+IENjOiBLYXRh cnp5bmEgRGVjIDxrYXRhcnp5bmEuZGVjQGludGVsLmNvbT4KPiBDYzogRGFuaWVsZSBDZXJhb2xv IFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiAtLS0KPiAgIGxpYi9p b2N0bF93cmFwcGVycy5jIHwgOTYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0KPiAgIGxpYi9pb2N0bF93cmFwcGVycy5oIHwgIDEgKwo+ICAgMiBmaWxlcyBjaGFu Z2VkLCA2OCBpbnNlcnRpb25zKCspLCAyOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv bGliL2lvY3RsX3dyYXBwZXJzLmMgYi9saWIvaW9jdGxfd3JhcHBlcnMuYwo+IGluZGV4IGY3MWYw ZTMyLi44Nzc0NGVkYyAxMDA2NDQKPiAtLS0gYS9saWIvaW9jdGxfd3JhcHBlcnMuYwo+ICsrKyBi L2xpYi9pb2N0bF93cmFwcGVycy5jCj4gQEAgLTczNiw2ICs3MzYsNDUgQEAgYm9vbCBnZW1fbW1h cF9faGFzX3djKGludCBmZCkKPiAgIAlyZXR1cm4gaGFzX3djID4gMDsKPiAgIH0KPiAgIAo+ICsv KioKPiArICogX19nZW1fbW1hcDoKPiArICogQGZkOiBvcGVuIGk5MTUgZHJtIGZpbGUgZGVzY3Jp cHRvcgo+ICsgKiBAaGFuZGxlOiBnZW0gYnVmZmVyIG9iamVjdCBoYW5kbGUKPiArICogQG9mZnNl dDogb2Zmc2V0IGluIHRoZSBnZW0gYnVmZmVyIG9mIHRoZSBtbWFwIGFyZW5hCj4gKyAqIEBzaXpl OiBzaXplIG9mIHRoZSBtbWFwIGFyZW5hCj4gKyAqIEBwcm90OiBtZW1vcnkgcHJvdGVjdGlvbiBi aXRzIGFzIHVzZWQgYnkgbW1hcCgpCj4gKyAqIEB3YzogZmxhZyBtYXJraW5nIGlmIHdlIHdhbnQg dG8gc2V0IHVwIE1NQVBfV0MgZmxhZwo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9ucyB3cmFwcyB1 cCBwcm9jZWR1cmUgdG8gZXN0YWJsaXNoIGEgbWVtb3J5IG1hcHBpbmcgdGhyb3VnaAo+ICsgKiBk aXJlY3QgY3B1IGFjY2VzcywgYnlwYXNzaW5nIHRoZSBncHUgKHZhbGlkIGZvciB3YyA9PSBmYWxz ZSkuIEZvciB3YyA9PSB0cnVlCj4gKyAqIGl0IGFsc28gYnlwYXNzIGNwdSBjYWNoZXMgY29tcGxl dGVseSBhbmQgR1RUIHN5c3RlbSBhZ2VudCAoaS5lLiB0aGVyZSBpcyBubwo+ICsgKiBhdXRvbWF0 aWMgdGlsaW5nIG9mIHRoZSBtbWFwcGluZyB0aHJvdWdoIHRoZSBmZW5jZSByZWdpc3RlcnMpLgo+ ICsgKgo+ICsgKiBSZXR1cm5zOiBBIHBvaW50ZXIgdG8gdGhlIGNyZWF0ZWQgbWVtb3J5IG1hcHBp bmcsIE5VTEwgb24gZmFpbHVyZS4KPiArICovCj4gK3ZvaWQgKl9fZ2VtX21tYXAoaW50IGZkLCB1 aW50MzJfdCBoYW5kbGUsIHVpbnQ2NF90IG9mZnNldCwgdWludDY0X3Qgc2l6ZSwgdW5zaWduZWQg cHJvdCwgYm9vbCB3YykKClRoaXMgc2hvdWxkbid0IGJlIGNhbGxlZCBmcm9tIG91dHNpZGUgdGhp cyBmaWxlLCBzbyB5b3UgY2FuIGp1c3QgbWFrZSBpdCAKc3RhdGljLgoKPiArewo+ICsJc3RydWN0 IGRybV9pOTE1X2dlbV9tbWFwIGFyZzsKPiArCj4gKwlpZiAod2MgJiAhZ2VtX21tYXBfX2hhc193 YyhmZCkpIHsKPiArCQllcnJubyA9IEVOT1NZUzsKPiArCQlyZXR1cm4gTlVMTDsKPiArCX0KPiAr Cj4gKwltZW1zZXQoJmFyZywgMCwgc2l6ZW9mKGFyZykpOwo+ICsJYXJnLmhhbmRsZSA9IGhhbmRs ZTsKPiArCWFyZy5vZmZzZXQgPSBvZmZzZXQ7Cj4gKwlhcmcuc2l6ZSA9IHNpemU7Cj4gKwlhcmcu ZmxhZ3MgPSB3YyA/IEk5MTVfTU1BUF9XQyA6IDA7Cj4gKwlpZiAoaWd0X2lvY3RsKGZkLCBEUk1f SU9DVExfSTkxNV9HRU1fTU1BUCwgJmFyZykpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwo+ICsJVkco VkFMR1JJTkRfTUFLRV9NRU1fREVGSU5FRChmcm9tX3VzZXJfcG9pbnRlcihhcmcuYWRkcl9wdHIp LCBhcmcuc2l6ZSkpOwo+ICsKPiArCWVycm5vID0gMDsKPiArCXJldHVybiBmcm9tX3VzZXJfcG9p bnRlcihhcmcuYWRkcl9wdHIpOwo+ICt9Cj4gKwo+ICAgLyoqCj4gICAgKiBfX2dlbV9tbWFwX193 YzoKPiAgICAqIEBmZDogb3BlbiBpOTE1IGRybSBmaWxlIGRlc2NyaXB0b3IKPiBAQCAtNzUzLDI1 ICs3OTIsMjAgQEAgYm9vbCBnZW1fbW1hcF9faGFzX3djKGludCBmZCkKPiAgICAqLwo+ICAgdm9p ZCAqX19nZW1fbW1hcF9fd2MoaW50IGZkLCB1aW50MzJfdCBoYW5kbGUsIHVpbnQ2NF90IG9mZnNl dCwgdWludDY0X3Qgc2l6ZSwgdW5zaWduZWQgcHJvdCkKPiAgIHsKPiAtCXN0cnVjdCBkcm1faTkx NV9nZW1fbW1hcCBhcmc7Cj4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX21tYXAgbW1hcF9h cmc7Cj4gICAKCkFueSByZWFzb24gbm90IHRvIGp1c3QgZG86Cgp2b2lkICpfX2dlbV9tbWFwX193 YyguLi4pCnsKCXJldHVybiBfX2dlbV9tbWFwKC4uLiwgdHJ1ZSk7Cn0KCj8KCj4gLQlpZiAoIWdl bV9tbWFwX19oYXNfd2MoZmQpKSB7Cj4gLQkJZXJybm8gPSBFTk9TWVM7Cj4gLQkJcmV0dXJuIE5V TEw7Cj4gLQl9Cj4gKyAgICAgICBtZW1zZXQoJm1tYXBfYXJnLCAwLCBzaXplb2YobW1hcF9hcmcp KTsKPiArICAgICAgIG1tYXBfYXJnLmhhbmRsZSA9IGhhbmRsZTsKPiArICAgICAgIG1tYXBfYXJn Lm9mZnNldCA9IG9mZnNldDsKPiArICAgICAgIG1tYXBfYXJnLnNpemUgPSBzaXplOwo+ICsgICAg ICAgbW1hcF9hcmcuZmxhZ3MgPSBJOTE1X01NQVBfV0M7Cj4gKyAgICAgICBpZiAoaWd0X2lvY3Rs KGZkLCBEUk1fSU9DVExfSTkxNV9HRU1fTU1BUCwgJm1tYXBfYXJnKSkKPiArICAgICAgICAgICAg ICAgcmV0dXJuIE5VTEw7Cj4gICAKPiAtCW1lbXNldCgmYXJnLCAwLCBzaXplb2YoYXJnKSk7Cj4g LQlhcmcuaGFuZGxlID0gaGFuZGxlOwo+IC0JYXJnLm9mZnNldCA9IG9mZnNldDsKPiAtCWFyZy5z aXplID0gc2l6ZTsKPiAtCWFyZy5mbGFncyA9IEk5MTVfTU1BUF9XQzsKPiAtCWlmIChpZ3RfaW9j dGwoZmQsIERSTV9JT0NUTF9JOTE1X0dFTV9NTUFQLCAmYXJnKSkKPiAtCQlyZXR1cm4gTlVMTDsK PiArICAgICAgIFZHKFZBTEdSSU5EX01BS0VfTUVNX0RFRklORUQoZnJvbV91c2VyX3BvaW50ZXIo bW1hcF9hcmcuYWRkcl9wdHIpLCBtbWFwX2FyZy5zaXplKSk7Cj4gICAKPiAtCVZHKFZBTEdSSU5E X01BS0VfTUVNX0RFRklORUQoZnJvbV91c2VyX3BvaW50ZXIoYXJnLmFkZHJfcHRyKSwgYXJnLnNp emUpKTsKPiAtCj4gLQllcnJubyA9IDA7Cj4gLQlyZXR1cm4gZnJvbV91c2VyX3BvaW50ZXIoYXJn LmFkZHJfcHRyKTsKPiArICAgICAgIGVycm5vID0gMDsKPiArICAgICAgIHJldHVybiBmcm9tX3Vz ZXJfcG9pbnRlcihtbWFwX2FyZy5hZGRyX3B0cik7CgpMb29rcyBsaWtlIHlvdSd2ZSBjaGFuZ2Vk IGFsbCB0YWJzIHRvIHNwYWNlcyBoZXJlLiBDYW4ganVzdCByZW1vdmUgaXQgCmFsbCBpZiB5b3Ug Zm9sbG93IHRoZSBhYm92ZSBzdWdnZXN0aW9uLgoKPiAgIH0KPiAgIAo+ICAgLyoqCj4gQEAgLTc4 MiwxMyArODE2LDE2IEBAIHZvaWQgKl9fZ2VtX21tYXBfX3djKGludCBmZCwgdWludDMyX3QgaGFu ZGxlLCB1aW50NjRfdCBvZmZzZXQsIHVpbnQ2NF90IHNpemUsIHVuCj4gICAgKiBAc2l6ZTogc2l6 ZSBvZiB0aGUgbW1hcCBhcmVuYQo+ICAgICogQHByb3Q6IG1lbW9yeSBwcm90ZWN0aW9uIGJpdHMg YXMgdXNlZCBieSBtbWFwKCkKPiAgICAqCj4gLSAqIExpa2UgX19nZW1fbW1hcF9fd2MoKSBleGNl cHQgd2UgYXNzZXJ0IG9uIGZhaWx1cmUuCj4gKyAqIFRoaXMgZnVuY3Rpb25zIHdyYXBzIHVwIHBy b2NlZHVyZSB0byBlc3RhYmxpc2ggYSBtZW1vcnkgbWFwcGluZyB0aHJvdWdoCj4gKyAqIGRpcmVj dCBjcHUgYWNjZXNzLCBieXBhc3NpbmcgdGhlIGdwdSBhbmQgY3B1IGNhY2hlcyBjb21wbGV0ZWx5 IGFuZCBhbHNvCj4gKyAqIGJ5cGFzc2luZyB0aGUgR1RUIHN5c3RlbSBhZ2VudCAoaS5lLiB0aGVy ZSBpcyBubyBhdXRvbWF0aWMgdGlsaW5nIG9mCj4gKyAqIHRoZSBtbWFwcGluZyB0aHJvdWdoIHRo ZSBmZW5jZSByZWdpc3RlcnMpLldlIGFzc2VydCBvbiBmYWlsdXJlLgo+ICAgICoKPiAgICAqIFJl dHVybnM6IEEgcG9pbnRlciB0byB0aGUgY3JlYXRlZCBtZW1vcnkgbWFwcGluZwo+ICAgICovCj4g ICB2b2lkICpnZW1fbW1hcF9fd2MoaW50IGZkLCB1aW50MzJfdCBoYW5kbGUsIHVpbnQ2NF90IG9m ZnNldCwgdWludDY0X3Qgc2l6ZSwgdW5zaWduZWQgcHJvdCkKPiAgIHsKPiAtCXZvaWQgKnB0ciA9 IF9fZ2VtX21tYXBfX3djKGZkLCBoYW5kbGUsIG9mZnNldCwgc2l6ZSwgcHJvdCk7Cj4gKwl2b2lk ICpwdHIgPSBfX2dlbV9tbWFwKGZkLCBoYW5kbGUsIG9mZnNldCwgc2l6ZSwgcHJvdCwgdHJ1ZSk7 CgpJZiB5b3UgZm9sbG93IHRoZSBhYm92ZSBzdWdnZXN0aW9uIGZvciBfX2dlbV9tbWFwX193YyB0 aGVuIHRoZXJlJ2xsIGJlIApubyBuZWVkIHRvIHVwZGF0ZSBoZXJlLgoKPiAgIAlpZ3RfYXNzZXJ0 KHB0cik7Cj4gICAJcmV0dXJuIHB0cjsKPiAgIH0KPiBAQCAtODEwLDE3ICs4NDcsMTcgQEAgdm9p ZCAqX19nZW1fbW1hcF9fY3B1KGludCBmZCwgdWludDMyX3QgaGFuZGxlLCB1aW50NjRfdCBvZmZz ZXQsIHVpbnQ2NF90IHNpemUsIHUKClRoZSBzYW1lIHN1Z2dlc3Rpb24gSSBoYWQgZm9yIHRoZSBf X3djIHBhdGggYXBwbHkgZm9yIF9fY3B1CgoKRGFuaWVsZQoKPiAgIHsKPiAgIAlzdHJ1Y3QgZHJt X2k5MTVfZ2VtX21tYXAgbW1hcF9hcmc7Cj4gICAKPiAtCW1lbXNldCgmbW1hcF9hcmcsIDAsIHNp emVvZihtbWFwX2FyZykpOwo+IC0JbW1hcF9hcmcuaGFuZGxlID0gaGFuZGxlOwo+IC0JbW1hcF9h cmcub2Zmc2V0ID0gb2Zmc2V0Owo+IC0JbW1hcF9hcmcuc2l6ZSA9IHNpemU7Cj4gLQlpZiAoaWd0 X2lvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9HRU1fTU1BUCwgJm1tYXBfYXJnKSkKPiAtCQlyZXR1 cm4gTlVMTDsKPiArICAgICAgIG1lbXNldCgmbW1hcF9hcmcsIDAsIHNpemVvZihtbWFwX2FyZykp Owo+ICsgICAgICAgbW1hcF9hcmcuaGFuZGxlID0gaGFuZGxlOwo+ICsgICAgICAgbW1hcF9hcmcu b2Zmc2V0ID0gb2Zmc2V0Owo+ICsgICAgICAgbW1hcF9hcmcuc2l6ZSA9IHNpemU7Cj4gKyAgICAg ICBpZiAoaWd0X2lvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9HRU1fTU1BUCwgJm1tYXBfYXJnKSkK PiArICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gICAKPiAtCVZHKFZBTEdSSU5EX01BS0Vf TUVNX0RFRklORUQoZnJvbV91c2VyX3BvaW50ZXIobW1hcF9hcmcuYWRkcl9wdHIpLCBtbWFwX2Fy Zy5zaXplKSk7Cj4gKyAgICAgICBWRyhWQUxHUklORF9NQUtFX01FTV9ERUZJTkVEKGZyb21fdXNl cl9wb2ludGVyKG1tYXBfYXJnLmFkZHJfcHRyKSwgbW1hcF9hcmcuc2l6ZSkpOwo+ICAgCj4gLQll cnJubyA9IDA7Cj4gLQlyZXR1cm4gZnJvbV91c2VyX3BvaW50ZXIobW1hcF9hcmcuYWRkcl9wdHIp Owo+ICsgICAgICAgZXJybm8gPSAwOwo+ICsgICAgICAgcmV0dXJuIGZyb21fdXNlcl9wb2ludGVy KG1tYXBfYXJnLmFkZHJfcHRyKTsKPiAgIH0KPiAgIAo+ICAgLyoqCj4gQEAgLTgzMSwxMyArODY4 LDE0IEBAIHZvaWQgKl9fZ2VtX21tYXBfX2NwdShpbnQgZmQsIHVpbnQzMl90IGhhbmRsZSwgdWlu dDY0X3Qgb2Zmc2V0LCB1aW50NjRfdCBzaXplLCB1Cj4gICAgKiBAc2l6ZTogc2l6ZSBvZiB0aGUg bW1hcCBhcmVuYQo+ICAgICogQHByb3Q6IG1lbW9yeSBwcm90ZWN0aW9uIGJpdHMgYXMgdXNlZCBi eSBtbWFwKCkKPiAgICAqCj4gLSAqIExpa2UgX19nZW1fbW1hcF9fY3B1KCkgZXhjZXB0IHdlIGFz c2VydCBvbiBmYWlsdXJlLgo+ICsgKiBUaGlzIGZ1bmN0aW9ucyB3cmFwcyB1cCBwcm9jZWR1cmUg dG8gZXN0YWJsaXNoIGEgbWVtb3J5IG1hcHBpbmcgdGhyb3VnaAo+ICsgKiBkaXJlY3QgY3B1IGFj Y2VzcywgYnlwYXNzaW5nIHRoZSBncHUgY29tcGxldGVseSBhbmQgd2UgYXNzZXJ0IG9uIGZhaWx1 cmUuCj4gICAgKgo+ICAgICogUmV0dXJuczogQSBwb2ludGVyIHRvIHRoZSBjcmVhdGVkIG1lbW9y eSBtYXBwaW5nCj4gICAgKi8KPiAgIHZvaWQgKmdlbV9tbWFwX19jcHUoaW50IGZkLCB1aW50MzJf dCBoYW5kbGUsIHVpbnQ2NF90IG9mZnNldCwgdWludDY0X3Qgc2l6ZSwgdW5zaWduZWQgcHJvdCkK PiAgIHsKPiAtCXZvaWQgKnB0ciA9IF9fZ2VtX21tYXBfX2NwdShmZCwgaGFuZGxlLCBvZmZzZXQs IHNpemUsIHByb3QpOwo+ICsJdm9pZCAqcHRyID0gX19nZW1fbW1hcChmZCwgaGFuZGxlLCBvZmZz ZXQsIHNpemUsIHByb3QsIGZhbHNlKTsKPiAgIAlpZ3RfYXNzZXJ0KHB0cik7Cj4gICAJcmV0dXJu IHB0cjsKPiAgIH0KPiBkaWZmIC0tZ2l0IGEvbGliL2lvY3RsX3dyYXBwZXJzLmggYi9saWIvaW9j dGxfd3JhcHBlcnMuaAo+IGluZGV4IGIyMmIzNmIwLi41MWU2NmMwOCAxMDA2NDQKPiAtLS0gYS9s aWIvaW9jdGxfd3JhcHBlcnMuaAo+ICsrKyBiL2xpYi9pb2N0bF93cmFwcGVycy5oCj4gQEAgLTk3 LDYgKzk3LDcgQEAgdm9pZCAqZ2VtX21tYXBfX3djKGludCBmZCwgdWludDMyX3QgaGFuZGxlLCB1 aW50NjRfdCBvZmZzZXQsIHVpbnQ2NF90IHNpemUsIHVuc2kKPiAgIHZvaWQgKl9fZ2VtX21tYXBf X2d0dChpbnQgZmQsIHVpbnQzMl90IGhhbmRsZSwgdWludDY0X3Qgc2l6ZSwgdW5zaWduZWQgcHJv dCk7Cj4gICB2b2lkICpfX2dlbV9tbWFwX19jcHUoaW50IGZkLCB1aW50MzJfdCBoYW5kbGUsIHVp bnQ2NF90IG9mZnNldCwgdWludDY0X3Qgc2l6ZSwgdW5zaWduZWQgcHJvdCk7Cj4gICB2b2lkICpf X2dlbV9tbWFwX193YyhpbnQgZmQsIHVpbnQzMl90IGhhbmRsZSwgdWludDY0X3Qgb2Zmc2V0LCB1 aW50NjRfdCBzaXplLCB1bnNpZ25lZCBwcm90KTsKPiArdm9pZCAqX19nZW1fbW1hcChpbnQgZmQs IHVpbnQzMl90IGhhbmRsZSwgdWludDY0X3Qgb2Zmc2V0LCB1aW50NjRfdCBzaXplLCB1bnNpZ25l ZCBwcm90LCBib29sIHdjKTsKPiAgIAo+ICAgaW50IGdlbV9tdW5tYXAodm9pZCAqcHRyLCB1aW50 NjRfdCBzaXplKTsKPiAgIAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1k ZXYK