Re: [PATCH i-g-t] tests/kms_async_flip: Reduce the clobbering area used for CRC test

[Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>]

Hi Vandita,

On 8.2.2024 14.10, Vandita Kulkarni wrote:
> On some platforms wc_mmap write takes longer to paint the fb,
> which we are using to clobber the already scanned buffer for
> CRC. Hence reducing the clobbered area.
> 
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
>   tests/kms_async_flips.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index a0349fa03..2e5960943 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -589,7 +589,7 @@ static void test_crc(data_t *data)
>   
>   	while (clock_ms() - start < 2000) {
>   		/* fill the next fb with the expected color */
> -		paint_fb(data, &data->bufs[frame], 1, height, 0xff0000ff);
> +		paint_fb(data, &data->bufs[frame], 10, 10, 0xff0000ff);

Here really is needed to be painted full height of the framebuffer and 
that width can be kept at 1 as any number higher will just increase the 
work.

For async flip part of fb which will become visible is not known here so 
the full height of the fb need to be painted on to catch if there was 
something going wrong.

>   
>   		data->flip_pending = true;
>   		ret = drmModePageFlip(data->drm_fd, data->crtc_id, data->bufs[frame].fb_id,
> @@ -600,7 +600,7 @@ static void test_crc(data_t *data)
>   
>   		/* clobber the previous fb which should no longer be scanned out */
>   		frame = !frame;
> -		paint_fb(data, &data->bufs[frame], 1, height, rand());
> +		paint_fb(data, &data->bufs[frame], 10, 10, rand());
>   	}
>   
>   	igt_pipe_crc_stop(data->pipe_crc);