Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: "Balasubramanyam, Smitha" <smitha.balasubramanyam@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"Kempczynski, Zbigniew" <zbigniew.kempczynski@intel.com>
Subject: Re: [PATCH v2 3/3] tests/intel/xe_ccs : Add CCS corruption neg test for VM_BIND decomp
Date: Mon, 22 Jun 2026 16:21:21 +0100	[thread overview]
Message-ID: <84ea27a5-9d38-4a15-9b6b-19f104b6da99@intel.com> (raw)
In-Reply-To: <PH7PR11MB5863CC413D11255F8D88E8B285EF2@PH7PR11MB5863.namprd11.prod.outlook.com>

On 22/06/2026 07:08, Balasubramanyam, Smitha wrote:
> 
> On 15/06/2026 13:31, Smitha Balasubramanyam wrote:
>> Add a negative test covering VM_BIND decompression verification with
>> corrupted CCS metadata.
>   > > The test also exercises suspend and resume handling during the
>> corruption scenario.
> 
>> What is meant by corrupted CCS here? Is this userspace corrupting something? If so, why does the kernel care? Can you give some more details here please?
> 
> Sure, this testcase is not primarily a negative uAPI rejection check.
> The testcase exercises behavior when userspace intentionally corrupts CCS metadata, then issues VM_BIND with DECOMPRESS and compares outcomes:
> - corrupted-CCS path is expected to differ from source data
> - clean-CCS path is expected to match source data

Does it really matter if userspace tramples the CCS? I assume we already 
create a compressed surface and check that the decompress flag behaves 
as we expect. If we trample the CCS data, then yes that will be visible 
when we decompress, same as when it contains "normal" data. End result 
is the same with main surface being the uncompressed view taking into 
account whatever was in the CCS data (whether corrupted or not 
corrupted) + main surface, with CCS being updated as uncompressed.

If usespace corrupts the CCS then yes that will be visible when you 
decompress it, but that is the same if they corrupt the main surface 
with random garbage? But is it really worth validating that? I guess it 
not clear what we are actually validating here from kernel/hw pov?

If there is some angle here from hw pov you have in mind, with some kind 
of specially crafted CCS corruption trying to trigger something bad, 
then that sounds more like general CCS coverage, and not part of VM_BIND 
decompress flag? Since the decompress thing can be done just as easily 
from userpace directly. Idea with having the kernel do it, is just that 
in some cases it's in the best position to do it, but there is nothing 
special that the kernel does for the decompress part. Plus that flag is 
not universally supported.

> 
> I agree the current test name may not reflect this intent clearly.
> I can rename it to something more explicit, like below if you suggest :
> - vm-bind-decompress-ccs-corruption-behavior-check or
> - vm-bind-decompress-ccs-corruption-comparison
> 


  reply	other threads:[~2026-06-22 15:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  5:42 [PATCH 0/3] Negative tests for VM_BIND decompression Smitha Balasubramanyam
2026-05-27  5:42 ` [PATCH 1/3] tests/intel/xe_ccs : Add helpers and Negative test for VM_Bind Decomp Smitha Balasubramanyam
2026-05-27  5:42 ` [PATCH 2/3] tests/intel/xe_ccs: Add fault-mode helper and VM_BIND decomp neg test Smitha Balasubramanyam
2026-05-27  5:42 ` [PATCH 3/3] tests/intel/xe_ccs : Add CCS corruption neg test for VM_BIND decomp Smitha Balasubramanyam
2026-05-27  6:40 ` ✓ Xe.CI.BAT: success for Negative tests for VM_BIND decompression Patchwork
2026-05-27  6:42 ` ✓ i915.CI.BAT: " Patchwork
2026-05-27  8:39 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-27 13:21 ` ✓ i915.CI.Full: success " Patchwork
2026-06-15 12:31 ` [PATCH v2 0/3] " Smitha Balasubramanyam
2026-06-15 12:31   ` [PATCH v2 1/3] tests/intel/xe_ccs : Add helpers and Negative test for VM_Bind Decomp Smitha Balasubramanyam
2026-06-15 17:02     ` Matthew Auld
2026-06-15 17:06       ` Matthew Auld
2026-06-22  5:24         ` Balasubramanyam, Smitha
2026-06-22 14:50           ` Matthew Auld
2026-06-15 12:31   ` [PATCH v2 2/3] tests/intel/xe_ccs: Add fault-mode helper and VM_BIND decomp neg test Smitha Balasubramanyam
2026-06-15 12:31   ` [PATCH v2 3/3] tests/intel/xe_ccs : Add CCS corruption neg test for VM_BIND decomp Smitha Balasubramanyam
2026-06-15 17:05     ` Matthew Auld
2026-06-22  6:08       ` Balasubramanyam, Smitha
2026-06-22 15:21         ` Matthew Auld [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20  4:57 [PATCH 0/2] Negative tests for VM_BIND decompression Smitha Balasubramanyam
2026-05-25 11:40 ` [PATCH v2 0/3] " Smitha Balasubramanyam
2026-05-25 11:40   ` [PATCH v2 3/3] tests/intel/xe_ccs : Add CCS corruption neg test for VM_BIND decomp Smitha Balasubramanyam
2026-05-25 12:15 ` [PATCH v2 0/3] Negative tests for VM_BIND decompression Smitha Balasubramanyam
2026-05-25 12:15   ` [PATCH v2 3/3] tests/intel/xe_ccs : Add CCS corruption neg test for VM_BIND decomp Smitha Balasubramanyam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84ea27a5-9d38-4a15-9b6b-19f104b6da99@intel.com \
    --to=matthew.auld@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=smitha.balasubramanyam@intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox