From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A387C71136 for ; Sat, 14 Jun 2025 01:12:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4702710E686; Sat, 14 Jun 2025 01:12:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="e9uIH4Wu"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD40810E686 for ; Sat, 14 Jun 2025 01:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749863547; x=1781399547; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=3RcpR8pQLI0NLDT1d+7L/zXZ6tsqsvLEdnkuYF+D++8=; b=e9uIH4WuZKk9K6DVJhthpwrTsSHYL6Vhe1UgXMMgFj7pX50qxaOOC0L9 G7OzaWXq7ei8zn2irQS+0U9tDE42c4xPWY07wBtyaCrZ7J016tHHn2sbq Dm3tFrUDPD1OO1GAt6fiee82jjxi+MBbsq8uQ/xEaLEtS6lAW2Uzhay5o XklIvA74acDjoa1eRQNf7b487knlKjq947K60NofsRlcTHKDCnfEiNyRp 7dSV/QSDKa3xcofVe5oGh+0H//yIgzoCTx1hTYmk5USduaLrHULBhpYl8 NuSKAWrU71RMTG4KKKM6VzP9Al8JZZG3dxjzhlLhxoqKa4bE1qPnODWfs Q==; X-CSE-ConnectionGUID: orraACxfQa2fKuGs9SygcA== X-CSE-MsgGUID: ep4Dbx9tQTeG76r07Cr6Ag== X-IronPort-AV: E=McAfee;i="6800,10657,11463"; a="51199887" X-IronPort-AV: E=Sophos;i="6.16,235,1744095600"; d="scan'208";a="51199887" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2025 18:12:27 -0700 X-CSE-ConnectionGUID: 7e7zhc52T6WRt09tFG0vxQ== X-CSE-MsgGUID: kG+9a8vPSXa0sjXBcM4Ggg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,235,1744095600"; d="scan'208";a="147805753" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2025 18:12:27 -0700 Date: Fri, 13 Jun 2025 18:12:26 -0700 Message-ID: <851prnktxh.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: igt-dev@lists.freedesktop.org Cc: Umesh Nerlige Ramappa Subject: Re: [PATCH i-g-t 2/2] tools/xe-perf: Change xe_perf_recorder command line to use OA unit id In-Reply-To: <20250614010827.3477175-3-ashutosh.dixit@intel.com> References: <20250614010827.3477175-1-ashutosh.dixit@intel.com> <20250614010827.3477175-3-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 13 Jun 2025 18:08:27 -0700, Ashutosh Dixit wrote: > > Xe OA uapi identifies an OA unit by means of its OA unit id. > xe_perf_recorder was instead using engine class/instance to identify the OA > unit, in order to have a common command line with i915_perf_recorder. > > However, Xe KMD now supports new OA units, which don't have any associated > engines. This means that it is not possible to use engine class/instance to > identify these OA units and these OA units must instead be identified by > means of the OA unit id, as originally intended in Xe OA uapi. > > Therefore, change xe_perf_recorder command line to use OA unit id instead > of engine class/instance to identify the OA unit. After this patch is reviewed, we will create a gpuvis PR to update the xe_perf_recorder command line in gpuvis scripts.