From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6879DC369B2 for ; Mon, 14 Apr 2025 23:22:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E700310E330; Mon, 14 Apr 2025 23:22:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SNHC2eeY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id E5E8C10E330 for ; Mon, 14 Apr 2025 23:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744672954; x=1776208954; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=1TEBh8IGYnLSJcMIlzumJ3gKj/5hu1Iw2hqYTkUUa9k=; b=SNHC2eeY8RrXFOybBpelnG4/NrAwShL2OnNTAUzxBtHuk/5nFFj6d4zc r8L2sHrK9U1+/9gqU29wZJ9xCemsth7rKt2V+TzH+UZFNOP0R3cEHZxbJ VAhTYQJ4K6T2C96YYdKjP/6xERsEGxElmvxzplsQbsfceQU7PipimXJBe WT+5X42Mxh2V7dmKMzd9qZUnn73wZMrpL2JmR7rpSA9mdyiphOIwATVKh ha/kx6wnpf/6N7Paav0uKLu0mndnX6JSiDx8urWHGay8cpwJppLQbjYxp BowkETazyhSc2wfYzQBt/dyfmD8L+AdMRYtNogCK4prji/ZnuggJFAiny Q==; X-CSE-ConnectionGUID: eXVF2/9QQQmY/UGYJ8KX9Q== X-CSE-MsgGUID: p6pPwpzSSraEmpWu3405wg== X-IronPort-AV: E=McAfee;i="6700,10204,11403"; a="46292141" X-IronPort-AV: E=Sophos;i="6.15,213,1739865600"; d="scan'208";a="46292141" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2025 16:22:34 -0700 X-CSE-ConnectionGUID: uM5qTIodSGC1LtHxKXxD0Q== X-CSE-MsgGUID: jvbSZwq1T/muIAgbigd4Nw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,213,1739865600"; d="scan'208";a="129718929" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2025 16:22:34 -0700 Date: Mon, 14 Apr 2025 16:22:33 -0700 Message-ID: <851ptus4zq.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH i-g-t 6/6] tests/intel/xe_oa: Use TestOa metric set also for OAM In-Reply-To: References: <20250408181210.1052760-1-ashutosh.dixit@intel.com> <20250408181210.1052760-7-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 14 Apr 2025 15:41:22 -0700, Umesh Nerlige Ramappa wrote: > > On Tue, Apr 08, 2025 at 11:12:10AM -0700, Ashutosh Dixit wrote: > > The only means available for testing OA data is the TestOa metric set, so > > use that also for media OA. > > > > Signed-off-by: Ashutosh Dixit > > yeah, TestOa of OAM should be good enough. > > Reviewed-by: Umesh Nerlige Ramappa Unfortunately, looks like TestOa does *not* work for OAM, the counters are not incrementing by gpu_ticks etc. So this patch needs to be dropped. Thanks! > > > > --- > > tests/intel/xe_oa.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > > index f3ce37ff5a..0914054460 100644 > > --- a/tests/intel/xe_oa.c > > +++ b/tests/intel/xe_oa.c > > @@ -338,7 +338,7 @@ static struct intel_xe_perf_metric_set *metric_set(const struct drm_xe_engine_cl > > else if ((hwe->engine_class == DRM_XE_ENGINE_CLASS_VIDEO_DECODE || > > hwe->engine_class == DRM_XE_ENGINE_CLASS_VIDEO_ENHANCE) && > > HAS_OAM(devid)) > > - test_set_name = "MediaSet1"; > > + test_set_name = "TestOa"; > > else > > igt_assert(!"reached"); > > > > -- > > 2.48.1 > >