From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9FFAD591A9 for ; Mon, 18 Nov 2024 18:25:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 476E610E147; Mon, 18 Nov 2024 18:25:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="QOp2p+xD"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D6BE10E147 for ; Mon, 18 Nov 2024 18:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731954303; x=1763490303; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=TPZ3oVUa++FF7/95EhJMu6tu3zkx6nfNeC9IImEuQQE=; b=QOp2p+xDpVGE/8vuVtnd7jF6Vpb8ptZ7PGE4jex+D+x6H53blWymtJ11 xFKSD+EfwfBtXsSOK2RfsYOD2zPOCSB2misc+5JZdpZWC+ig665PYQ+NV clNMoybLId1uOs0+So1sfTyCFixysP/FsUNBL5Ze5Oezb2jaEFHDd5J/A cNTLwEkXqmEEifCaNtpKzeKX5vpvU25Tdvt24b4QQEI9GbCicnIxtm+Uh OgBjf19Z7RyRHRnOmM/C+nHUmKCfAMBqb0zqg5GROMN6TIoCrhoEjj6JF MA2dwbCUeOihxOFt06WtkxPST0USoNNN6Z+v6WYwap8odmnG3MaTIyxBf Q==; X-CSE-ConnectionGUID: BGWw0F9mRGWjtVSRtXSIQA== X-CSE-MsgGUID: P/dP/X7xSoSUd09xVd6sRg== X-IronPort-AV: E=McAfee;i="6700,10204,11260"; a="31864451" X-IronPort-AV: E=Sophos;i="6.12,164,1728975600"; d="scan'208";a="31864451" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2024 10:25:03 -0800 X-CSE-ConnectionGUID: ILAvv/UxS6C7A4oOaExTZg== X-CSE-MsgGUID: n6TvqyNURGO9/RXy/61vpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,164,1728975600"; d="scan'208";a="89456650" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2024 10:25:03 -0800 Date: Mon, 18 Nov 2024 10:25:02 -0800 Message-ID: <851pz8xuv5.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Souza, Jose" Cc: "igt-dev@lists.freedesktop.org" , "Nerlige\ Ramappa, Umesh" Subject: Re: [PATCH i-g-t] lib/xe/oa: Re-instate TestOa metric sets in LNL/BMG XML's In-Reply-To: References: <20241115022031.3794406-1-ashutosh.dixit@intel.com> <07c5107ce34654d1d484eb301d12e46831a22fb6.camel@intel.com> <854j44xxh5.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 18 Nov 2024 09:37:09 -0800, Souza, Jose wrote: > > On Mon, 2024-11-18 at 09:28 -0800, Dixit, Ashutosh wrote: > > On Mon, 18 Nov 2024 09:20:00 -0800, Souza, Jose wrote: > > > > > > > diff --git a/lib/xe/oa-configs/codegen.py b/lib/xe/oa-configs/codeg= en.py > > > > index 51498f803d..7251f5c7a6 100644 > > > > --- a/lib/xe/oa-configs/codegen.py > > > > +++ b/lib/xe/oa-configs/codegen.py > > > > @@ -352,6 +352,9 @@ class Gen: > > > > m =3D re.search(r'\$GtSlice([0-9]+)XeCore([0-9]+)$', name) > > > > if m: > > > > return 'intel_xe_perf_devinfo_subslice_available(&perf= ->devinfo, {0}, {1})'.format(m.group(1), m.group(2)) > > > > + m =3D re.search(r'\$GtXeCore([0-99]+)$', name) > > > > + if m: > > > > + return 'intel_xe_perf_devinfo_subslice_available(&perf= ->devinfo, {0}, 0)'.format(m.group(1)) > > > > > > Just note sure about this one, it have 8 GtXeCore so should be the > > > subslice/DSS not the slices. But you would also need need to ajust t= he > > > first parameter to take into consideration subslices in the second and > > > other slices or add a function that does this for you. > > > > Yup, I just put it in "something" there to make this compile for now. I > > want to add a FIXME here to fix later. > > > > It can be fixed later if anyone is going to use it. We don't know how to > > use this information yet, at least in IGT, so I am assuming this can be > > fixed if needed, if it's going to be used, at the time we try to actual= ly > > make use of the TestOa metric in IGT. > > > > Is there any use for this in Mesa? > > Not used by Mesa, so you can add my RB with a TODO comment here. > > Reviewed-by: Jos=E9 Roberto de Souza Thanks, I added a FIXME and went ahead and merged this. Ashutosh