Re: [PATCH i-g-t 3/3] drm-uapi/xe: Restore flags VM_BIND_FLAG_READONLY and VM_BIND_FLAG_IMMEDIATE

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 29 Mar 2024 08:30:58 -0700, Francois Dugast wrote:
>

Hi Francois,

> The commit ca4607939 ("drm/xe/uapi: Remove unused flags") is partially
> reverted. At the time, flags not used by user space were removed during
> cleanup. As a consequence, tests depending on those flags were also
> removed. Some of those flags are now needed by user space, so bring them
> back and the removed tests as well.
>
> Align with kernel commit ("drm/xe/uapi: Restore flags \
> VM_BIND_FLAG_READONLY and VM_BIND_FLAG_IMMEDIATE").
>
> Signed-off-by: Francois Dugast <francois.dugast@intel.com>
> ---
>  include/drm-uapi/xe_drm.h                |  8 +++
>  tests/intel-ci/xe-fast-feedback.testlist | 10 ++++
>  tests/intel/xe_exec_fault_mode.c         | 65 ++++++++++++++++++++----
>  tests/intel/xe_vm.c                      | 16 ++++--
>  4 files changed, 85 insertions(+), 14 deletions(-)
>
> diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
> index d8816df83..6cbfd8dc3 100644
> --- a/include/drm-uapi/xe_drm.h
> +++ b/include/drm-uapi/xe_drm.h
> @@ -871,6 +871,12 @@ struct drm_xe_vm_destroy {
>   *  - %DRM_XE_VM_BIND_OP_PREFETCH
>   *
>   * and the @flags can be:
> + *  - %DRM_XE_VM_BIND_FLAG_READONLY - Setup the page tables as read-only
> + *    to ensure write protection.

Hmm, this line in the kernel header is "to ensure write protection" so it
doesn't have the period. Maybe it should be fixed before we merge this?

Thanks.
--
Ashutosh