From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FE3ACAC592 for ; Fri, 19 Sep 2025 23:59:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4862B10E262; Fri, 19 Sep 2025 23:59:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="XZD0q9qu"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 006EB10E262 for ; Fri, 19 Sep 2025 23:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1758326394; x=1789862394; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=NxpRLfWqv5NiS3wi5s3nYUULEmuVq+AbrSJPQd3NR0s=; b=XZD0q9qu5vpdPoEiP43+KGM6yONcBzIRa+mztj1rPuQbhXNSDXbAuXAc VET2lAG7yMQzflas0nM2TUqYoayhwdZTFLcEbXkl0h1qiSqBLjnR5EVlF 4+ZMWIB8SoCwNcstkKLyKzuigXsdlBSKAd7O4NF9vFyOtBS2pOPYkw8fX 6+Ks85yB6YQKowQTWlV/A7tPDSkjp/NnG9elBHZwvAo1MYzdTynC1b51g zkpE4uuT/Jlepi4NCUrfAgBxJ1/82DZvCnydUnDe4PUrB2brxa8aJGaYa 0+ambmbF5Ln3RszEacaR1SKPmq/b0e388lo9rvHJU6Ka1EiEJ+5IxOG5F g==; X-CSE-ConnectionGUID: caVH0ZUcQ5q7K4p5OUz/CQ== X-CSE-MsgGUID: f7gkFbnZRbe4IpomMqMoRw== X-IronPort-AV: E=McAfee;i="6800,10657,11558"; a="63308489" X-IronPort-AV: E=Sophos;i="6.18,279,1751266800"; d="scan'208";a="63308489" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2025 16:59:53 -0700 X-CSE-ConnectionGUID: rBvJnshqQNee8wp2J1tDQw== X-CSE-MsgGUID: +9IluwdVRlaqs512srPwQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,279,1751266800"; d="scan'208";a="199677291" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.88.27.185]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2025 16:59:53 -0700 Date: Fri, 19 Sep 2025 16:59:52 -0700 Message-ID: <854isyxabr.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Daniel Charles Cc: igt-dev@lists.freedesktop.org Subject: Re: [PATCH] tests/intel/xe_exec_reset: expect error or complete on CAT_ERROR In-Reply-To: <20250919222836.82407-1-daniel.charles@intel.com> References: <20250919222836.82407-1-daniel.charles@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 19 Sep 2025 15:28:36 -0700, Daniel Charles wrote: > > when running cm job, it could be that after the fence is checked, a > CAT_ERROR will throw an error in the same way as GT_RESET does. > > Signed-off-by: Daniel Charles > --- > tests/intel/xe_exec_reset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c > index 7ae53c679..73c5c7e20 100644 > --- a/tests/intel/xe_exec_reset.c > +++ b/tests/intel/xe_exec_reset.c > @@ -433,7 +433,7 @@ test_compute_mode(int fd, struct drm_xe_engine_class_instance *eci, > > err = __xe_wait_ufence(fd, &data[i].exec_sync, USER_FENCE_VALUE, > exec_queues[i % n_exec_queues], &timeout); > - if (flags & GT_RESET) > + if (flags & GT_RESET || flags & CAT_ERROR) Hi Daniel, 1. Is there a gitlab bug about this? If yes, could you please add a 'Closes:' tag to this patch (see git log) 2. Would you have a reference to the kernel code that a CAT error returns -EIO? Thanks. -- Ashutosh > /* exec races with reset: may return -EIO or complete */ > igt_assert(err == -EIO || !err); > else > -- > 2.43.0 >