From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A9EAC2BA18 for ; Thu, 20 Jun 2024 23:05:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ADD1010E15B; Thu, 20 Jun 2024 23:05:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WSCHhD9N"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id CDAF610E15B for ; Thu, 20 Jun 2024 23:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718924733; x=1750460733; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=faWyGC489/pRLVX6fuiIZJKFHtk7nJgSFU4UdwXLdnY=; b=WSCHhD9N442yLmB2pPU0xc8I2P43J4z7LpFeDRy3kMGj23qEDyupR4pv QX7jv0HvWXUYTSbG/ANmjqfimK+oPYHmmqf7NviWgts589a+Gh9hto3T9 DshYIYW5SMhZ5xLPYfeTnRbVd09WiYbQR1eN+GWeifq4TqjHBC/4jsp0t YT8RF7N0rLnCm2TezGI766L2TOEyxfcEQJuKD4mvBkParMI0FBP2Ga6z/ bNE9+rF5g2lw64R6yRrUYZCJT8sZ7osyblai/d7RnGSYPt4wB9QSpn5Kb wtpfxHd2BI/e/Xjp1pp/AgZ6DMwRWp8/o2qNaAV2aOvTCzuPrlAfirUG+ w==; X-CSE-ConnectionGUID: hSY/fkahSyOAODKOb7pHlg== X-CSE-MsgGUID: lg+yYROmSO+rQhvB/d9xjg== X-IronPort-AV: E=McAfee;i="6700,10204,11109"; a="15768307" X-IronPort-AV: E=Sophos;i="6.08,253,1712646000"; d="scan'208";a="15768307" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 16:05:33 -0700 X-CSE-ConnectionGUID: 0IWKXFAJTF2NhoG7cng/9g== X-CSE-MsgGUID: jg416IknS4u8v6hV9vaVXw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,253,1712646000"; d="scan'208";a="73138863" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 16:05:33 -0700 Date: Thu, 20 Jun 2024 16:05:32 -0700 Message-ID: <854j9nqkoz.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: igt-dev@lists.freedesktop.org Subject: Re: [PATCH i-g-t 05/28] lib/xe/oa: Generate LNL metrics/registers files In-Reply-To: References: <20240620200054.3550653-1-ashutosh.dixit@intel.com> <20240620200054.3550653-6-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Thu, 20 Jun 2024 14:52:51 -0700, Umesh Nerlige Ramappa wrote: > > On Thu, Jun 20, 2024 at 01:00:30PM -0700, Ashutosh Dixit wrote: > > @@ -138,9 +138,22 @@ def generate_metric_sets(args, gen): > > metric_set->c_offset = metric_set->b_offset + 8; > > metric_set->perfcnt_offset = metric_set->c_offset + 8; > > """)) > > + elif gen.chipset == "lnl": > > + c(textwrap.dedent("""\ > > + metric_set->perf_oa_format = XE_OA_FORMAT_PEC64u64; > > + > > + metric_set->perf_raw_size = 576; > > + metric_set->gpu_time_offset = 0; > > + metric_set->gpu_clock_offset = 1; > > + metric_set->a_offset = 2; > > + // metric_set->b_offset = metric_set->a_offset + 38; > > + // metric_set->c_offset = metric_set->b_offset + 8; > > Above 2 lines can be dropped if unused > > Reviewed-by: Umesh Nerlige Ramappa Jose has added a 4 patches to the series. The patch "xe/oa/oa-metricset-codegen: Fix XE_OA_FORMAT_PEC64u64 offsets" deletes these lines, so maybe ok to leave as is. Thanks.