From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB387CD128A for ; Tue, 9 Apr 2024 17:31:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CC76112E68; Tue, 9 Apr 2024 17:31:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="iWaQR5YX"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 064AD112E67 for ; Tue, 9 Apr 2024 17:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712683864; x=1744219864; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=JOqasQxsI/Q4pU/TlC02AKGz1g0ZRMpLMQhByFqeZd0=; b=iWaQR5YXrp5wf3jhdX3jUbauCFgwrMs9Shra5tVvXt9o+EshU8jpXKCI YaKNOzqQbDswE61gMoOz6JMJf511gd4jYALAFeRLh37VuWMrH8/3PlS6W x9KlDw8OpiPKT8XIjUDlJrDw9BN1xc73EhjTIEGoHQK1uQYTI07lJsPRe czbamAy7Iv5kh3Nx3UlU6yv3e57Me6uXUjDyT3rAXafTjm3JHn7y2hNWv 5eEbOnVtJKkj1zhG/mg7Wv8UqNPb1tRGTlv7Ifw7INswjuuC8VbyQsuLg ZWt2RkYeJIuqOu+y1V3/BjeiwmACj8D6jBH8gRs83cimBXV705o7t6c4b g==; X-CSE-ConnectionGUID: bped3Qk1TL6O+nhme6LPVA== X-CSE-MsgGUID: 8BWGssP8Sk207zFpiEc0GA== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="8117132" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="8117132" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 10:31:03 -0700 X-CSE-ConnectionGUID: Tc6FniWSR/ivwpnV5XBmrg== X-CSE-MsgGUID: dF/PDKCrThyzW1HxiABWrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="51503424" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 10:31:03 -0700 Date: Tue, 09 Apr 2024 10:31:02 -0700 Message-ID: <854jca30kp.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Francois Dugast Cc: igt-dev@lists.freedesktop.org Subject: Re: [PATCH i-g-t 2/3] drm-uapi/xe: Define topology types as indexes rather than masks In-Reply-To: <20240329153058.7-3-francois.dugast@intel.com> References: <20240329153058.7-1-francois.dugast@intel.com> <20240329153058.7-3-francois.dugast@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 29 Mar 2024 08:30:57 -0700, Francois Dugast wrote: > > Align with kernel commit ca83f9d20171 ("drm/xe/uapi: Define topology \ > types as indexes rather than masks"). > > This is not a functional change. Matches defines in drm-xe-next: Reviewed-by: Ashutosh Dixit > Signed-off-by: Francois Dugast > --- > include/drm-uapi/xe_drm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h > index 91ea92035..d8816df83 100644 > --- a/include/drm-uapi/xe_drm.h > +++ b/include/drm-uapi/xe_drm.h > @@ -518,9 +518,9 @@ struct drm_xe_query_topology_mask { > /** @gt_id: GT ID the mask is associated with */ > __u16 gt_id; > > -#define DRM_XE_TOPO_DSS_GEOMETRY (1 << 0) > -#define DRM_XE_TOPO_DSS_COMPUTE (1 << 1) > -#define DRM_XE_TOPO_EU_PER_DSS (1 << 2) > +#define DRM_XE_TOPO_DSS_GEOMETRY 1 > +#define DRM_XE_TOPO_DSS_COMPUTE 2 > +#define DRM_XE_TOPO_EU_PER_DSS 4 > /** @type: type of mask */ > __u16 type; > > -- > 2.34.1 >