Re: [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops

Ser, Simon
2019-05-07T15:10:48Z

On Tue, 2019-05-07 at 15:31 +0100, Chris Wilson wrote:
> Quoting Simon Ser (2019-05-07 13:44:41)
> > The loop condition is never satisfied, since after filling the
> > array i > 0. For
> > this reason the loop is always a no-op.
> >
> > Use a more conventional loop instead.
>
> Or a classic while loop? Bad me for not reading the check was
> back-to-front.

You mean while(i--)?

I generally prioritize code clarity in these situations, hence the for
loop. Also not a fan of decrementing operators returning a value.