From: "Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
igt-dev@lists.freedesktop.org
Cc: marcin.bernatowicz@intel.com, kamil.konieczny@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] Revert "testplan/kms: Make documentation is mandatory for all kms subtests"
Date: Fri, 18 Aug 2023 13:54:43 +0200 [thread overview]
Message-ID: <85990200-c88a-2651-1293-a70313e99a74@linux.intel.com> (raw)
In-Reply-To: <20230818113817.155989-1-juhapekka.heikkila@gmail.com>
On 8/18/2023 1:38 PM, Juha-Pekka Heikkila wrote:
> This change broke igt build when building without chamelium
>
> This reverts commit 00bc4cf384382018ebe6f333e4d53849c883445b.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> docs/testplan/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build
> index 433464dc8..e838f2eb1 100644
> --- a/docs/testplan/meson.build
> +++ b/docs/testplan/meson.build
> @@ -31,13 +31,13 @@ xe_test_dict = {
> if build_xe
> test_dict = {
> 'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
> - 'kms_tests': { 'input': kms_test_config, 'extra_args': check_testlist },
> + 'kms_tests': { 'input': kms_test_config, 'extra_args': [] },
> 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist }
> }
> else
> test_dict = {
> 'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
> - 'kms_tests': { 'input': kms_test_config, 'extra_args': check_testlist }
> + 'kms_tests': { 'input': kms_test_config, 'extra_args': [] }
> }
> endif
>
LGTM, verified build does not fail on docker with chamelium disabled.
Acked-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
next prev parent reply other threads:[~2023-08-18 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 11:38 [igt-dev] [PATCH i-g-t] Revert "testplan/kms: Make documentation is mandatory for all kms subtests" Juha-Pekka Heikkila
2023-08-18 11:50 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2023-08-18 11:54 ` Bernatowicz, Marcin [this message]
2023-08-18 12:07 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-08-18 12:21 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-19 18:07 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85990200-c88a-2651-1293-a70313e99a74@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@intel.com \
--cc=marcin.bernatowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox