From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE003C3ABCC for ; Tue, 13 May 2025 16:43:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F81C10E221; Tue, 13 May 2025 16:43:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="E1z6ucIx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id DFE1510E142 for ; Tue, 13 May 2025 16:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747154614; x=1778690614; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=jlYTkDtGDp0bGs1jPGSzseIknTaOIveQ7uzVjHnyntU=; b=E1z6ucIx3zJqjvlUSYVAlNWu9dqtjNZBdxv42tdxZVkFhRR6Qtf2Y/Py nx6+VjoRWD73XdTxvqZc9oNZfVKgAyWLHUebBUyeO6Z7Sd7k17+r+Eahd v4ScVPFPzB99HKancmlX1ghAoiHLf3nUJuEhcO+ZM6APf80IxG4Lg6Ie1 Yr70IMKzXuqK5pQhqmRMtKBV6ZzoCWjovOR3Q9PNlgskgnojJ0CZRnnCH OpwqaxcJ5Dk26ikDNC5CigrX0tJNL/rwy+LcKReumu/aRTxM12s1QgsYA F1xVl91Mk3yZigM7/j174LLqS4FUQJC7wn1MJW1kcJNBcBEPDJIC5vT5G A==; X-CSE-ConnectionGUID: iNC0F+pQQDWUPj7w2cynIA== X-CSE-MsgGUID: 6Zk7azIpSx+BePCtQq665w== X-IronPort-AV: E=McAfee;i="6700,10204,11432"; a="60414012" X-IronPort-AV: E=Sophos;i="6.15,285,1739865600"; d="scan'208";a="60414012" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2025 09:43:34 -0700 X-CSE-ConnectionGUID: oCiRK7WnTcmcFcA1RpwXJg== X-CSE-MsgGUID: fkrnBebkTGWdhuRRgyef/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,285,1739865600"; d="scan'208";a="142528000" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2025 09:43:34 -0700 Date: Tue, 13 May 2025 09:43:32 -0700 Message-ID: <85a57glavf.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH i-g-t 1/1] tests/intel/xe_eu_stall: Do not check for presence of data on simulation In-Reply-To: <7480b4adc93d3606d60d718d269c92791c22df68.1747105491.git.harish.chegondi@intel.com> References: <7480b4adc93d3606d60d718d269c92791c22df68.1747105491.git.harish.chegondi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 12 May 2025 20:07:38 -0700, Harish Chegondi wrote: > > Some simulation models may not have full EU stall sampling support. > > Signed-off-by: Harish Chegondi > --- > tests/intel/xe_eu_stall.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/intel/xe_eu_stall.c b/tests/intel/xe_eu_stall.c > index 411c30871..bdfa0fc4b 100644 > --- a/tests/intel/xe_eu_stall.c > +++ b/tests/intel/xe_eu_stall.c > @@ -586,7 +586,6 @@ enable: > > ret = wait_child(&work_load); > igt_assert_f(ret == 0, "waitpid() - ret: %d, errno: %d\n", ret, errno); > - igt_assert_f(num_samples, "No EU stalls detected during the workload\n"); > > do_ioctl(stream_fd, DRM_XE_OBSERVATION_IOCTL_DISABLE, 0); > if (--iter) > @@ -594,6 +593,9 @@ enable: > > close(stream_fd); > free(buf); > + > + if (!igt_run_in_simulation()) > + igt_assert_f(num_samples, "No EU stalls detected during the workload\n"); Do we really want to move this here? Wasn't the earlier location better since it checked num_samples for every iteration, whereas now we'd check it only for the last iteration? > } > > static int opt_handler(int opt, int opt_index, void *data) > -- > 2.48.1 >