From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F14EE77199 for ; Thu, 9 Jan 2025 05:15:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED6F310E2BA; Thu, 9 Jan 2025 05:15:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="k067nPkj"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2490210E2BA for ; Thu, 9 Jan 2025 05:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736399733; x=1767935733; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=U/jUjgi4hm2SGgQXm+kqNHxMjhLzksc/73Twqyw/7VQ=; b=k067nPkjDRW5ZQlxMsnzU8+1ts7+mrONTjAdqQysaqmFdm5IT8mQdPcP EIp7XfrgEiVAKdIWO26CJFqh6MWginDcywWoXDaCy6NXdXcuxLodt0vEO o3AM5HeXydh1092ZmzdVwVke6mUKP28eguoCNOlwrKF7/9g5Husf17f9l WMe14Og12aMzziw8c/fvBu83lH/Gz5dSwH8AjezNgRyQ/ttIm1EAT7/5e rMtQDvHWRElJnAGX8eOia5OAxx8tbMmbm5S2jxfXpHx4yEpdCyO4giKA6 Kfe4gJcGZdENcFMQjqgO0lBNqa2rwdt7Wrk9vBnVgLMxs+OrB6hIl6qXF w==; X-CSE-ConnectionGUID: iGjPe8SGROqQkzkUTkmI7Q== X-CSE-MsgGUID: Rx2sXxvuSgWhN5eICllR0w== X-IronPort-AV: E=McAfee;i="6700,10204,11309"; a="48005644" X-IronPort-AV: E=Sophos;i="6.12,300,1728975600"; d="scan'208";a="48005644" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2025 21:15:33 -0800 X-CSE-ConnectionGUID: ERO22iRhQp6LaY63R0aE9w== X-CSE-MsgGUID: lkV7OQhxSGuboaBBP6hsog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="140613222" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2025 21:15:33 -0800 Date: Wed, 08 Jan 2025 21:15:32 -0800 Message-ID: <85a5c0va8b.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Pottumuttu, Sai Teja" Cc: Subject: Re: [PATCH i-g-t] drm-uapi/xe: Sync with OA uapi updates In-Reply-To: References: <20250109032331.2774067-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 08 Jan 2025 20:26:18 -0800, Pottumuttu, Sai Teja wrote: > > On 09-01-2025 08:53, Ashutosh Dixit wrote: > > Align with kernel commit 5637797add2a ("drm/xe/oa/uapi: Expose an unblock > > after N reports OA property"). > > > > Signed-off-by: Ashutosh Dixit > > --- > > include/drm-uapi/xe_drm.h | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h > > index 56163eb913..08e263b3b2 100644 > > --- a/include/drm-uapi/xe_drm.h > > +++ b/include/drm-uapi/xe_drm.h > > @@ -134,7 +134,7 @@ extern "C" { > > * redefine the interface more easily than an ever growing struct of > > * increasing complexity, and for large parts of that interface to be > > * entirely optional. The downside is more pointer chasing; chasing across > > - * the __user boundary with pointers encapsulated inside u64. > > + * the boundary with pointers encapsulated inside u64. > > I think this line change doesn't exist in kernel. Was it intentionally > changed here for some reason? No, the file is automatically generated with 'make headers_install' in the kernel. 'make headers_install' will remove all '__user' tags, because __user only makes sense in the kernel, not in userspace. This seems to be the only instance of __user in xe_drm.h but there are many more instances of __user in i915_drm.h. You can see __user being removed by comparing i915_drm.h files between kernel and IGT. > > With that addressed, > Reviewed-by: Sai Teja Pottumuttu Thanks! > > Thanks, > Sai Teja > > > * > > * Example chaining: > > * > > @@ -1486,6 +1486,8 @@ struct drm_xe_oa_unit { > > __u64 capabilities; > > #define DRM_XE_OA_CAPS_BASE (1 << 0) > > #define DRM_XE_OA_CAPS_SYNCS (1 << 1) > > +#define DRM_XE_OA_CAPS_OA_BUFFER_SIZE (1 << 2) > > +#define DRM_XE_OA_CAPS_WAIT_NUM_REPORTS (1 << 3) > > /** @oa_timestamp_freq: OA timestamp freq */ > > __u64 oa_timestamp_freq; > > @@ -1651,6 +1653,20 @@ enum drm_xe_oa_property_id { > > * to the VM bind case. > > */ > > DRM_XE_OA_PROPERTY_SYNCS, > > + > > + /** > > + * @DRM_XE_OA_PROPERTY_OA_BUFFER_SIZE: Size of OA buffer to be > > + * allocated by the driver in bytes. Supported sizes are powers of > > + * 2 from 128 KiB to 128 MiB. When not specified, a 16 MiB OA > > + * buffer is allocated by default. > > + */ > > + DRM_XE_OA_PROPERTY_OA_BUFFER_SIZE, > > + > > + /** > > + * @DRM_XE_OA_PROPERTY_WAIT_NUM_REPORTS: Number of reports to wait > > + * for before unblocking poll or read > > + */ > > + DRM_XE_OA_PROPERTY_WAIT_NUM_REPORTS, > > }; > > /**