From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68C58C4828D for ; Mon, 5 Feb 2024 16:37:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 06BAC10E738; Mon, 5 Feb 2024 16:37:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WvaiIZb6"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9649B10E738 for ; Mon, 5 Feb 2024 16:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707151078; x=1738687078; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=lfe4Gd9U2RcvxyWQos6U17S+LCk3LYjAAmZ7mfJNcLE=; b=WvaiIZb6sGEs0AJwS4D9TKV7Uf1ZmvSDmaODU+FW2K3TaJKLsjDF+0gO otSJi9Rto5ZydAV+hih/U0hwrN6kzpdSjxeOOnfhdssTfk9NzkfDlpEHD NpUT7HsoD1cL+GvJbcekeFnIRS9uJf4IU9MYEjRzskvnlBiwryLwfbqeI qa3C6Ijyhpx9qKQlgrahZcoyqJlztMtDNLYRFNlHZ5gHAfREMty1FgOFY ZG1Xg50XfPXwt0h6s9KJDb01vcV3B49kVwYHfHjXknGAeClvPh3j0e6N3 9RO1aopeuiBwGdSJb2nH4+Lx1T0Cx6+PYhLRHCXZvfgROqgjKd55aQZ64 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="23038132" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="23038132" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 08:37:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="24006387" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 08:37:56 -0800 Date: Mon, 05 Feb 2024 08:37:55 -0800 Message-ID: <85a5oec1ek.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Chaitanya Kumar Borah Cc: igt-dev@lists.freedesktop.org, Umesh Nerlige Ramappa Subject: Re: [PATCH i-g-t] lib: Add ARL-S PCI ID for perf tests In-Reply-To: <20240205060139.3643855-1-chaitanya.kumar.borah@intel.com> References: <20240205060139.3643855-1-chaitanya.kumar.borah@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Sun, 04 Feb 2024 22:01:39 -0800, Chaitanya Kumar Borah wrote: > Hi Chaitanya, > Enable perf tests on ARL-S > > Signed-off-by: Chaitanya Kumar Borah > --- > lib/i915_pciids_local.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/i915_pciids_local.h b/lib/i915_pciids_local.h > index a0ca29ee7..0043b0cd9 100644 > --- a/lib/i915_pciids_local.h > +++ b/lib/i915_pciids_local.h > @@ -10,7 +10,8 @@ > /* MTL perf */ > #ifndef INTEL_MTL_M_IDS > #define INTEL_MTL_M_IDS(info) \ > - INTEL_VGA_DEVICE(0x7D60, info) > + INTEL_VGA_DEVICE(0x7D60, info), \ > + INTEL_VGA_DEVICE(0x7D67, info) 1. Did you check if this fixes the OA tests on ARL? Or this will enable the testing? 2. Why not include all ARL PCI ID's? Seem to be already there in kernel include/drm/i915_pciids.h. Also: https://gfxspecs.intel.com/Predator/Home/Index/55420 3. How about moving all these MTL/ARL ID's into lib/i915_pciids.h from lib/i915_pciids_local.h? Thanks. -- Ashutosh