From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31898C021B5 for ; Sat, 22 Feb 2025 00:43:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF88110E0E9; Sat, 22 Feb 2025 00:43:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="k7/m3SUG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88A9410E0E9 for ; Sat, 22 Feb 2025 00:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740185027; x=1771721027; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=5olZf1MzmZXgNJp1AsF8PWnhSM9dLyyEL+zOZHFc7l0=; b=k7/m3SUGR9dceZBR20tMittNjlnu9FWntJ4tgfXk4ZpToxK51wq26LTS 0+ombNXS+LgwDG4fcDB0VzOd8fXVwW/SEvzBAaRtDoNjCT/A7GxGDfCLH IDXdwLU1ihQeME6pOE5OLdJhu9U0mnPM9EbP2qThmdHLmtxHjKSMg9mgP 7wFNRl//WrYRQ+edjZz8pQaVNQA7i6sFrBotMva2XcSxQ1llfbLKbPpQC 9itGHrpOsR38W6AR/noGOS/tcWEQRpkRssPOTE7/WyBXr5x+mYo++cxna BY1R99QdNaGAI1SfDY87XUNu3subrak40j8g8mO67U4zgZDdr52xEXHkf g==; X-CSE-ConnectionGUID: 6hV4oClvTxqJBMp2UtTnxg== X-CSE-MsgGUID: OH1uBDjwQoyzbWjpUY4DZw== X-IronPort-AV: E=McAfee;i="6700,10204,11352"; a="41033836" X-IronPort-AV: E=Sophos;i="6.13,306,1732608000"; d="scan'208";a="41033836" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 16:43:46 -0800 X-CSE-ConnectionGUID: yv8z97UXRPGIjwfGYTV1ow== X-CSE-MsgGUID: 92D+ZTRdTZOzjP7UeijlcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="120759451" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 16:43:46 -0800 Date: Fri, 21 Feb 2025 16:43:46 -0800 Message-ID: <85bjuuolkt.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH i-g-t CI run 04/14] tests/intel/xe_oa: Use default exponent for some tests In-Reply-To: References: <20250218202812.1679653-1-umesh.nerlige.ramappa@intel.com> <20250218202812.1679653-5-umesh.nerlige.ramappa@intel.com> <85eczqom9f.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 21 Feb 2025 16:37:53 -0800, Umesh Nerlige Ramappa wrote: > > On Fri, Feb 21, 2025 at 04:29:00PM -0800, Dixit, Ashutosh wrote: > > On Tue, 18 Feb 2025 12:28:02 -0800, Umesh Nerlige Ramappa wrote: > >> > >> Use the default exponent for below tests: > >> > >> oa-tlb-validate > >> short-reads > >> stress-open-close > >> mmio-triggered-reports > > > > Why? Let's add a reason in the commit message, for all the patches, even > > if, in this case, it might be "because it doesn't matter what exponent is > > used". > > That's open for discussion in this review. My reasoning: > > Other than the stress-open-close, none of the other tests actually depend > on the oa exponent, so we might as well use one value everywhere. Yeah that's what I thought. > > > > > Because these tests were ported from i915 I myself don't quite understand > > why some of these tests do what the do. So it will help if we could > > document why we are making the changes we are making, and, when needed, > > what the effect of the changes is going to be. > > There is one patch on top of this series which should adjust the exponent > value for all tests so that they run quickly on simulation. Maybe I should > post the v2 with that patch so the context is clear, otherwise, I agree > that the reason for these changes is unclear. Either way, or just state on the patch something like: "this would allow these tests to run in a reasonable time on slower platforms". Oops, should have commented on the original series, but ended up commenting on the CI series :/ Thanks. -- Ashutosh