From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66A5BD1713B for ; Mon, 21 Oct 2024 21:03:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F24110E056; Mon, 21 Oct 2024 21:03:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="k4hYaSaz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F0D310E056 for ; Mon, 21 Oct 2024 21:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729544628; x=1761080628; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=7nDyxFbt8bD4NrC4zhY654Ye7j/3kyQbn/DV+OZzNT0=; b=k4hYaSazGrPurnprMj+cs6sxQ13J2/4JDU0nTDjQ7d2dKg3haeqWdndT uBlKAszEUQsX1GdrO0v90ktcX3/1Xn0DDEsBHsB7gJSAFsEV2d3X4Xecm ZFeyXcLFYh5BLOrUH5+DcOIDniXugkuTYYgAAI6r1kMIbdGwHMVYtyFyu N9i9+Zd+nMYugmgYdbbtaSyNkTQ8Yb8s/Xn5VjrnCJVGl3j2Yai5J2ZWz XyeIXR2Hy5jho/LMgk1A00RR18JrmF8j+jXXi/38MKuY/GPEUHLag+k9+ 0HAwuq17VYAfBmg0Ra6vW12Qws7lw3Fzk6+2dSKBYJW3BU/QmrTCu7Xkz A==; X-CSE-ConnectionGUID: 3dvom9FOSCeWvSrRmujwyA== X-CSE-MsgGUID: VZgxHKsJQTCDxe3aNvn8uw== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="28823265" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="28823265" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2024 14:03:47 -0700 X-CSE-ConnectionGUID: Ra6DhAczRu+m+FvqIXQNsg== X-CSE-MsgGUID: 4A4kXsFZRsCcA2/c1ikxjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,221,1725346800"; d="scan'208";a="110409393" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2024 14:03:46 -0700 Date: Mon, 21 Oct 2024 14:03:46 -0700 Message-ID: <85bjzd2mod.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: igt-dev@lists.freedesktop.org Subject: Re: [PATCH i-g-t] lib/xe/oa: Don't skip if freq sysfs are not present In-Reply-To: References: <20241021181203.1094596-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 21 Oct 2024 13:55:29 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, > On Mon, Oct 21, 2024 at 11:12:03AM -0700, Ashutosh Dixit wrote: > > Freq sysfs are not created in certain environments. In most of these cases > > OA IGT's will work just fine, even when GT min/max freq's are not > > known. Therefore, just print a warning if freq sysfs are not present but > > don't cause tests to skip. > > > > Signed-off-by: Ashutosh Dixit > > --- > > lib/xe/xe_oa.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/lib/xe/xe_oa.c b/lib/xe/xe_oa.c > > index 86264230c9..189388b76b 100644 > > --- a/lib/xe/xe_oa.c > > +++ b/lib/xe/xe_oa.c > > @@ -571,11 +571,9 @@ xe_perf_for_fd(int drm_fd, int gt) > > } > > > > if (!read_sysfs(sysfs_dir_fd, path_min, >_min_freq) || > > - !read_sysfs(sysfs_dir_fd, path_max, >_max_freq)) { > > + !read_sysfs(sysfs_dir_fd, path_max, >_max_freq)) > > igt_warn("Unable to read freqs from sysfs\n"); > > 1) Well.. you would still end up with an igt_warn. CI will still complain, > I guess. Is that acceptable? I don't know if igt_warn causes CI to create a bug or only dmesg-warn does that? Let me change to igt_info (or igt_debug). > > 2) If called from an application (i.e. gpuvis), does the igt_warn show up > in stdout? Yes igt_warn/info etc will show in stdout or stderr. > For IGT, I don't see oa tests using this, so it's probably okay. If the > answer for 1 and 2 is yes, then this is Not upstream tests. > > Reviewed-by: Umesh Nerlige Ramappa Thanks but will post another version. -- Ashutosh > > - close(sysfs_dir_fd); > > - return NULL; > > - } > > + > > close(sysfs_dir_fd); > > > > device_id = intel_get_drm_devid(drm_fd); > > -- > > 2.41.0 > >