From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9CEBC021B3 for ; Sat, 22 Feb 2025 00:31:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 989AE10E0E9; Sat, 22 Feb 2025 00:31:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SncHYXma"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 395E910E0E9 for ; Sat, 22 Feb 2025 00:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740184273; x=1771720273; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=3lNQACHUOUlFSD5IRaLcp1JTBDkgRAzLG+p1HL3ZByA=; b=SncHYXmaKKJO/dN6PQ4TLQYAV6kVxmFztF4dZ+kNWyhcxOY4oEqsJOnp EgSspDNlkuPFOTQILUD2yv7I/7g0g1l+JdkjgzHuGYzgybDL406wojpSs VpAapXFGj8BVlsr1QyGMjO1QLA01UtuQx1nJi7wKdCXewhnj6XxzU8oOi 26QODY3/pxYebeBen6SwwCPgJyGtfpCO31TpE35rslqwfFR9PsXE5EZ9S lxOrFF2B2zcz7E2QK1zOZK4BU5G3HZZjgZ2JQ4r6qbdSFEvvOBpAW0hIa RhViAseoqAwhGnmrZWSqTqct3rFsDBi4Wqe8+fUb+L0WFhWWuayPW/iTc Q==; X-CSE-ConnectionGUID: zwc3lBFPQv6neGJuWoGxGg== X-CSE-MsgGUID: qW1doUB5QMmz81o7Mf/9Ng== X-IronPort-AV: E=McAfee;i="6700,10204,11352"; a="52418632" X-IronPort-AV: E=Sophos;i="6.13,306,1732608000"; d="scan'208";a="52418632" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 16:31:12 -0800 X-CSE-ConnectionGUID: hGWbYbnfTcqI7W3sPCHFuQ== X-CSE-MsgGUID: v+lZGzDRTvSFQc1knBaLvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,306,1732608000"; d="scan'208";a="120429098" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 16:31:12 -0800 Date: Fri, 21 Feb 2025 16:31:11 -0800 Message-ID: <85cyfaom5s.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH i-g-t CI run 03/14] tests/intel/xe_oa: Rename oa_exp_1_millisec to oa_exponent_default In-Reply-To: References: <20250218202812.1679653-1-umesh.nerlige.ramappa@intel.com> <20250218202812.1679653-4-umesh.nerlige.ramappa@intel.com> <85frk6omgx.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 21 Feb 2025 16:29:03 -0800, Umesh Nerlige Ramappa wrote: > > On Fri, Feb 21, 2025 at 04:24:30PM -0800, Dixit, Ashutosh wrote: > > On Tue, 18 Feb 2025 12:28:01 -0800, Umesh Nerlige Ramappa wrote: > >> > >> Rename the global exponent to default so it can be used in different > >> modes. > >> > >> Signed-off-by: Umesh Nerlige Ramappa > >> --- > >> tests/intel/xe_oa.c | 34 +++++++++++++++++----------------- > >> 1 file changed, 17 insertions(+), 17 deletions(-) > >> > >> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > >> index 9c74315df..e7d6ac5af 100644 > >> --- a/tests/intel/xe_oa.c > >> +++ b/tests/intel/xe_oa.c > >> @@ -299,7 +299,7 @@ static uint32_t devid; > >> static struct drm_xe_engine_class_instance default_hwe; > >> > >> static struct intel_xe_perf *intel_xe_perf; > >> -static uint64_t oa_exp_1_millisec; > >> +static uint64_t oa_exponent_default; > >> static size_t default_oa_buffer_size; > >> static struct intel_mmio_data mmio_data; > >> static igt_render_copyfunc_t render_copy; > >> @@ -514,7 +514,7 @@ static size_t get_default_oa_buffer_size(int fd) > >> /* OA unit configuration */ > >> DRM_XE_OA_PROPERTY_OA_METRIC_SET, default_test_set->perf_oa_metrics_set, > >> DRM_XE_OA_PROPERTY_OA_FORMAT, __ff(default_test_set->perf_oa_format), > >> - DRM_XE_OA_PROPERTY_OA_PERIOD_EXPONENT, oa_exp_1_millisec, > >> + DRM_XE_OA_PROPERTY_OA_PERIOD_EXPONENT, oa_exponent_default, > > > > My suggestion here would be to (a) either rename this to > > oa_exponent_default_1ms, or alternatively, (b) to rename the period > > argument of max_oa_exponent_for_period_lte() to period_ns. So it's clear > > from the code, without having to guess, what the value of the default > > exponent is. > > So, the idea is to set this default to a smaller value like 1000 ns for > simulation, so that it gets applied to all the tests, hence not using any > specific values in the name. Thoughts? Then let's do (b).