From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 635BECDD0F4 for ; Tue, 22 Oct 2024 20:45:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 15C9A10E1B8; Tue, 22 Oct 2024 20:45:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="n2+yVcvx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1500B10E1B8 for ; Tue, 22 Oct 2024 20:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729629927; x=1761165927; h=date:message-id:from:to:subject:in-reply-to:references: mime-version; bh=MiVJDspuEvm+Pi7NRPFWcfPW8TMxUOdovqsLvUfMmik=; b=n2+yVcvx+9ci7xIcfeagq96EP+Wlfq0xT3mKXhHE2NG713NgC8Z/xnNk ZjPruuFCXlSUvCXk1SIhWudIYElcl8saT5MpUSLIdjZRd4jsrGP3u2HuV jTdJ9ba8H+KLOUwOzuNWkV119IjlAVu9gWn/a+QxCFBehjg773PR1jPDX OP81jsPy9k5u7GOp2oAy+Ct7dclQ7gpbo/sW7O3rpnJB22eOrxu1LNdaV bOwCKHe0/DZI7JTBzEqtSSwJ4fS3+mC4Dyr6AA4MBCL59Ya4pJ2qYdYL/ 7qytvEwy/W2UOhV8ZImATXfixMtaqdesW8eilz7vi/PlK09LDfHqz9ert w==; X-CSE-ConnectionGUID: e5m/txi+RtOfwPssXBb3Xg== X-CSE-MsgGUID: e7DrB13XRYqKEAlYQZbLqw== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29309166" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29309166" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2024 13:45:27 -0700 X-CSE-ConnectionGUID: W+DSR//LRH+mE5rTf4rM1w== X-CSE-MsgGUID: Cw6BDADFTNOhEGkleJzu+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,223,1725346800"; d="scan'208";a="79907009" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2024 13:45:26 -0700 Date: Tue, 22 Oct 2024 13:45:26 -0700 Message-ID: <85cyjrvpcp.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , igt-dev@lists.freedesktop.org, Ashutosh Dixit Subject: Re: [PATCH i-g-t] tests/intel/oa: Check exec_queue is usable after closing OA stream In-Reply-To: <20241014141913.s3w5wf2xqwc7lkuu@kamilkon-desk.igk.intel.com> References: <20240921004506.3280863-1-ashutosh.dixit@intel.com> <20241014141913.s3w5wf2xqwc7lkuu@kamilkon-desk.igk.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 14 Oct 2024 07:19:13 -0700, Kamil Konieczny wrote: > > Hi Ashutosh, > On 2024-09-20 at 17:45:06 -0700, Ashutosh Dixit wrote: > > please fix subject: > > tests/intel/oa: Check exec_queue is usable after closing OA stream > > should be: > > tests/intel/xe_oa: Check exec_queue is usable after closing OA stream Sure. Will change in all pending patches. > > > Add a test case to verify that batch buffers submitted on an exec_queue, > ^^^^^^^^^^^^^^^ > imho here: > Add repeated verification for ... > or: > Repeat twice a verification for usablility of batch buffers.... Probably not, latest version has a 16 loop. > > > after closing the OA stream, do indeed complete. This test is in related to > > https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2821 where this was > > first noticed. > > > > Signed-off-by: Ashutosh Dixit > > --- > > tests/intel/xe_oa.c | 23 ++++++++++++++++++++++- > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > > index 506646789c..eb19fdec97 100644 > > --- a/tests/intel/xe_oa.c > > +++ b/tests/intel/xe_oa.c > > @@ -3018,13 +3018,34 @@ test_mi_rpc(struct drm_xe_engine_class_instance *hwe) > > igt_assert_neq(report32[format.b_off >> 2], 0x80808080); > > igt_assert_eq(report32[format_size_32], 0x80808080); > > > > + intel_buf_unmap(buf); > > + __perf_close(stream_fd); > > + > > + /* > > + * Re-do MI_RPC after closing perf stream, and check batch buffers > > + * submitted on exec_queue still complete > > + */ > > Instead of copy-paste, wouldn't it be better to write a function > and call it twice here? Probably not worth it either. Anyway we need to bottom out on the kernel/HW issue first, so unlikely that this will get merged till that happens. Thanks. -- Ashutosh > > > + buf_map(drm_fd, buf, true); > > + memset(buf->ptr, 0x80, 4096); > > + intel_buf_unmap(buf); > > + > > + intel_bb_flush_render(ibb); > > + intel_bb_sync(ibb); > > + > > + buf_map(drm_fd, buf, false); > > + report32 = buf->ptr; > > + format_size_32 = format.size >> 2; > > + dump_report(report32, format_size_32, "mi-rpc"); > > + > > + igt_assert_eq(report32[0], 0x80808080); > > + igt_assert_eq(oa_timestamp(report32, test_set->perf_oa_format), 0x80808080); > > + > > intel_buf_unmap(buf); > > intel_buf_destroy(buf); > > intel_bb_destroy(ibb); > > xe_exec_queue_destroy(drm_fd, ctx_id); > > xe_vm_destroy(drm_fd, vm); > > buf_ops_destroy(bops); > > - __perf_close(stream_fd); > > } > > > > static void > > -- > > 2.41.0 > >