From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03EC5C021B3 for ; Sat, 22 Feb 2025 00:29:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 848B910E193; Sat, 22 Feb 2025 00:29:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mJBSEag4"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 268D110E0E9 for ; Sat, 22 Feb 2025 00:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740184142; x=1771720142; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Y/E1XUEXuoR2W4VyD8wEv+hf0M09oYjRjxNy4cnHe0E=; b=mJBSEag4OD4dgaYCS2U1zpMsYjbJpvQ1mzkCyoSCnu3S9XKThRQOA3Jt sQYIEgdLWi7k/MZkCaQ7+MraN4hO3LQNF4YWd0yijMGFlOq7AbjEIi+49 DMOLl80s/E7X8wTLW3AsbpFKdroUoXCENSv9ETSIB6uw1qgAlnbfL76ph h0+Y3XBJonwabEbkQeXW/2v/po+x3xhC5tRUIeKijIRmdMakPEm2dLG2i xFObILhqWNctJPEBDAgJxOSoD0tlFRU/6frcv3Z4ZSK49jcd+3XuVUatQ qn13uPhiMaPKXvPoP4Rh0lA49B7zAQDLgD0+JrOaY5O6DNbkzWasb11ia Q==; X-CSE-ConnectionGUID: 94hv5QTARKa0IZ1HfK8Gaw== X-CSE-MsgGUID: KrI0wvIJT2uLKAMRwtgLyQ== X-IronPort-AV: E=McAfee;i="6700,10204,11352"; a="58565502" X-IronPort-AV: E=Sophos;i="6.13,306,1732608000"; d="scan'208";a="58565502" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 16:29:01 -0800 X-CSE-ConnectionGUID: f4uj4zYfSr+tNSRF+bTsVA== X-CSE-MsgGUID: hlHS0QAfSq67Zbbl9vE00w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="120757168" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 16:29:02 -0800 Date: Fri, 21 Feb 2025 16:29:00 -0800 Message-ID: <85eczqom9f.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH i-g-t CI run 04/14] tests/intel/xe_oa: Use default exponent for some tests In-Reply-To: <20250218202812.1679653-5-umesh.nerlige.ramappa@intel.com> References: <20250218202812.1679653-1-umesh.nerlige.ramappa@intel.com> <20250218202812.1679653-5-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 18 Feb 2025 12:28:02 -0800, Umesh Nerlige Ramappa wrote: > > Use the default exponent for below tests: > > oa-tlb-validate > short-reads > stress-open-close > mmio-triggered-reports Why? Let's add a reason in the commit message, for all the patches, even if, in this case, it might be "because it doesn't matter what exponent is used". Because these tests were ported from i915 I myself don't quite understand why some of these tests do what the do. So it will help if we could document why we are making the changes we are making, and, when needed, what the effect of the changes is going to be. Thanks. -- Ashutosh