From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB7D2C021B2 for ; Sat, 22 Feb 2025 03:32:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4909A10E004; Sat, 22 Feb 2025 03:32:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="crY75ndA"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB03310E004 for ; Sat, 22 Feb 2025 03:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740195127; x=1771731127; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Cicpr3JLfdpMPG13B/8pnIj8c1JGsP9AcHoXeG0rSEE=; b=crY75ndATrLi/u/EE3WfJYs1/JNP2PHYDPUaFsi1uy/kFB7PN71n0Omd JVQF1y0rUXnt6buE92mvO9O8p+9R79VMnjV+aqH21TZXYULqXQ0bhyu5V LoLZbbCn9cogNshM7T000MroKSnA9S2xk0smwxF0jEQwnmfv3TkB3g8aM P5Ln+zWqguovLlW8u7Rb7TsB5BScg2dYOahD8B2wNHHJ84DXZQs0u288C ZMcnPETYSHMJynrAufxy7dQ53aZz1Xko/0bcs9+maRmtXEcsD7O/5wNCS 7NN4GHtxGYTG05rRQoRts3yQNcy1UlPL8B0jGWR3yP4sFHqIJvrhUGoaI Q==; X-CSE-ConnectionGUID: Rn9w9zg8SQyK8bmiyL29OA== X-CSE-MsgGUID: n3jD/S3OS/e6U+DDFiwvcg== X-IronPort-AV: E=McAfee;i="6700,10204,11352"; a="40943064" X-IronPort-AV: E=Sophos;i="6.13,306,1732608000"; d="scan'208";a="40943064" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 19:32:06 -0800 X-CSE-ConnectionGUID: S0rPQgZKRGaM+/ULmteMSQ== X-CSE-MsgGUID: Z3ELNH9kSs2DKrp9Q+ppEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="119657509" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 19:32:06 -0800 Date: Fri, 21 Feb 2025 19:32:05 -0800 Message-ID: <85eczqy7re.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH 12/13] tests/intel/xe_oa: Fix mmio_trigger_reports testing In-Reply-To: <20250215010628.1639986-13-umesh.nerlige.ramappa@intel.com> References: <20250215010628.1639986-1-umesh.nerlige.ramappa@intel.com> <20250215010628.1639986-13-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 14 Feb 2025 17:06:27 -0800, Umesh Nerlige Ramappa wrote: > > The MI_STORE command needs modification to set the right amount of dwords. While > at it, set the default exponent and add a render_copy check. What is the second sentence here referring to, please fix: Reviewed-by: Ashutosh Dixit > > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index ff1b873d5..d44832a8a 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -3688,7 +3688,7 @@ emit_oa_reg_read(struct intel_bb *ibb, struct intel_buf *dst, uint32_t offset, > { > intel_bb_add_intel_buf(ibb, dst, true); > > - intel_bb_out(ibb, MI_STORE_REGISTER_MEM | 2); > + intel_bb_out(ibb, MI_STORE_REGISTER_MEM_GEN8); > intel_bb_out(ibb, reg); > intel_bb_emit_reloc(ibb, dst->handle, > I915_GEM_DOMAIN_INSTRUCTION, > -- > 2.34.1 >