From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60A90C282C6 for ; Mon, 3 Mar 2025 19:11:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EDF8810E4BB; Mon, 3 Mar 2025 19:11:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ddsxXc9I"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD0E910E4BB for ; Mon, 3 Mar 2025 19:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741029091; x=1772565091; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=cIMU+flNvJWJINoPo6AYwruUL1gtJ31fIxvfh3D+keY=; b=ddsxXc9IsKEk35E77zAL1CTyH9zlRSOyKsvehsDxn2kXQpFl7kExCNRa SRLaf2bKWEUvu+9alNX6ZGW9K63+sIilR+wvnJZnq6CbaJ3rbJkylZuMC jDdJy905md+kq2oOAfP02dwTob4tNPZpFnVOWKgFzRZZmZbDEv4ybG4YN F2UuUxVHLhgvMTYY3pFbul4jYQ+ucCFPsBuLFsM/ZX99LvyN5P3oz+ewr sJylgFwSNuItggxjl5g+wIg9YGvgqYs4yHP3j7lXHP8drxgntnW+mSPho /LgbagAesXz69UoyT1yJN+f7CV0dWTkHy+yeilPKzoXR4+VTnByW/Ccr0 A==; X-CSE-ConnectionGUID: guJwLcl5Tm2he6xWKz3tNA== X-CSE-MsgGUID: WVCCvCRuQhyeoUsQh+uMgQ== X-IronPort-AV: E=McAfee;i="6700,10204,11362"; a="52558614" X-IronPort-AV: E=Sophos;i="6.13,330,1732608000"; d="scan'208";a="52558614" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 11:11:31 -0800 X-CSE-ConnectionGUID: OHR559fpRZKs1C2cKSXr/w== X-CSE-MsgGUID: X5u0nKgnQ9OPSGFpnNiaAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="155319276" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 11:11:30 -0800 Date: Mon, 03 Mar 2025 11:11:29 -0800 Message-ID: <85frju53q6.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH i-g-t v2 2/2] tests/intel/xe_eu_stall: Add tests for EU stall sampling In-Reply-To: <97b6c6425406e966c8831aec0d26ef6d53c8b4dd.1739901972.git.harish.chegondi@intel.com> References: <97b6c6425406e966c8831aec0d26ef6d53c8b4dd.1739901972.git.harish.chegondi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 18 Feb 2025 10:21:27 -0800, Harish Chegondi wrote: > > +const char *help_str = " --event_count | -e\t\tPoll event report count\n" > + " --gt_id | -g\t\tGT ID for the GT to sample EU stalls\n" > + " --output | -o\t\tOutput file to write EU stall data\n" > + " --rate | -r\t\tSampling rate in GPU cycles\n" > + " --user_buf_sz | -u\t\tUser buffer size\n" > + " --workload | -w\t\tWorkload to run\n"; > + > +static struct option long_options[] = { > + {"event_count", 0, 0, 'e'}, > + {"gt_id", 0, 0, 'g'}, > + {"output", 0, 0, 'o'}, > + {"rate", 0, 0, 'r'}, > + {"user_buf_sz", 0, 0, 'u'}, > + {"workload", 0, 0, 'w'}, > + { NULL, 0, 0, 0 } The tests should probably be extended in the future by iterating over some of these parameters (such as user buffer size, sampling rate, event count). But this is good patch is good enough starting point, so this is now: Reviewed-by: Ashutosh Dixit