From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23B6FC021B3 for ; Sat, 22 Feb 2025 00:18:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DBE4F10E0E9; Sat, 22 Feb 2025 00:18:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="kO5+1+GD"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4674810E0E9 for ; Sat, 22 Feb 2025 00:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740183519; x=1771719519; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=cRk0zXSHIQGwf7z0xg3lybYumTuUE/SQHinLJvMwAUE=; b=kO5+1+GDkrQJXx4IaqveA1c2nWwD8hRRqiwU23X4qaZOY8w4yXDVlf99 iUZIG+WUF+PT3teUbyCWpVUg4kkfVJsfRDd+CfSmoxHMD2hywtfhjGMY1 Kd0hUft2h5kVrm3yvmAXVZh39jRXUZkJwDS7v9/lfc0P+2u5CXvN2s1ZZ 1gfzOd0pVgIZZQ4tbPGFNl8Kt8nMuwveF1Vqfdsrmv1G6/86BbmlqE3Zn /2YiLy3Iiv4Sm+iXwi/xzKQKmCTjhO0GBDrgkMP77q9hm5SCZXvwKCJ41 bohjcAIgJIq/DNJsqCTzL0wc4dv0EgqTZQcBhPRzyGqyAASvhwij4rsJR Q==; X-CSE-ConnectionGUID: wP1OkRh1STqWeJqQc02K9Q== X-CSE-MsgGUID: i9wHdkdXRg6uUrYAmsAbvA== X-IronPort-AV: E=McAfee;i="6700,10204,11352"; a="44927023" X-IronPort-AV: E=Sophos;i="6.13,306,1732608000"; d="scan'208";a="44927023" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 16:18:39 -0800 X-CSE-ConnectionGUID: C5xmaWMlSpOIcAMsXHiffQ== X-CSE-MsgGUID: 7HS55RQoQZWLcHNfQfPJdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,306,1732608000"; d="scan'208";a="115706779" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 16:18:38 -0800 Date: Fri, 21 Feb 2025 16:18:38 -0800 Message-ID: <85h64momqp.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: , , , Subject: Re: [PATCH i-g-t v2] lib/igt_core: Add ftrace logs at test boundaries In-Reply-To: <20250221223823.2336228-1-umesh.nerlige.ramappa@intel.com> References: <20250221223823.2336228-1-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 21 Feb 2025 14:38:23 -0800, Umesh Nerlige Ramappa wrote: > > When looking at kernel ftrace output, it would really help to see the > test start/exit boundaries. > > v2: Fix copy paste error Reviewed-by: Ashutosh Dixit > Signed-off-by: Umesh Nerlige Ramappa > --- > lib/igt_core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/igt_core.c b/lib/igt_core.c > index b95db1b25..9702a9417 100644 > --- a/lib/igt_core.c > +++ b/lib/igt_core.c > @@ -1324,6 +1324,7 @@ out: > if (!igt_only_list_subtests()) { > bind_fbcon(false); > igt_kmsg(KMSG_INFO "%s: executing\n", command_str); > + igt_trace("%s: executing\n", command_str); > print_version(); > igt_srandom(); > > @@ -1528,6 +1529,7 @@ bool __igt_run_subtest(const char *subtest_name, const char *file, const int lin > > igt_kmsg(KMSG_INFO "%s: starting subtest %s\n", > command_str, subtest_name); > + igt_trace("%s: starting subtest %s\n", command_str, subtest_name); > _subtest_starting_message(_SUBTEST_TYPE_NORMAL, subtest_name); > > _igt_log_buffer_reset(); > @@ -1681,6 +1683,8 @@ __noreturn static void exit_subtest(const char *result) > igt_time_elapsed(thentime, &now)); > igt_kmsg(KMSG_INFO "%s: finished subtest %s, %s\n", > command_str, *subtest_name, result); > + igt_trace("%s: finished subtest %s, %s\n", > + command_str, *subtest_name, result); > > igt_terminate_spins(); > > -- > 2.34.1 >