From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBD58C021B3 for ; Sat, 22 Feb 2025 03:10:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EBB810E004; Sat, 22 Feb 2025 03:10:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CHzpIfut"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id B46A710E004 for ; Sat, 22 Feb 2025 03:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740193851; x=1771729851; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=uzUHcM4800IslK7pnepg3IVVxXdTwWgICS9B/pco2E0=; b=CHzpIfutGMNEp/psZKXY2MxQGJ7A/u2D5vKUVSak4dNbkLzzPK3q2/wu WmLidKw1gR3B4lceK/J099T2HJwxrtCSDHcJq9qQzKBNFkkPWISkAEkgg 5ewj1SxZr57Rh8Fm6Wwxx1iAeBAAFn4y7K4SjmISgyGf/FAjI+yrMVfkG vofEwp7iG+zT6J81tU7RjH4SnLWIEJep6VzVmzIhLE33DvuYK6jknoiA+ +rLXLno6Z4JyOs9RtZiWSY8Amu7A2k5b3s+8eXPFyy1UkijA6xYcHw4pt +HuyAwr82bf9rzW0tA7/u0+unSYKDow1y+z8KZIR7Ae/1/f6GARN6/GUf Q==; X-CSE-ConnectionGUID: vom1lryhRjyM73a83jKDuA== X-CSE-MsgGUID: or+cQIHES7OuICEhGmJHyQ== X-IronPort-AV: E=McAfee;i="6700,10204,11352"; a="41145029" X-IronPort-AV: E=Sophos;i="6.13,306,1732608000"; d="scan'208";a="41145029" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 19:10:51 -0800 X-CSE-ConnectionGUID: 0DReI22NQGWfbHP6cMZrmw== X-CSE-MsgGUID: ueEwPmN6TOq4vMLIbZGCzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,306,1732608000"; d="scan'208";a="146385070" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 19:10:50 -0800 Date: Fri, 21 Feb 2025 19:10:49 -0800 Message-ID: <85ikp2y8qu.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH 08/13] tests/intel/xe_oa: Use default buffer size for non-zero reason In-Reply-To: <20250215010628.1639986-9-umesh.nerlige.ramappa@intel.com> References: <20250215010628.1639986-1-umesh.nerlige.ramappa@intel.com> <20250215010628.1639986-9-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 14 Feb 2025 17:06:23 -0800, Umesh Nerlige Ramappa wrote: > > Use a default buffer size for non-zero-reason for and strip > out testing buffer size in the same test. OK, this is cleaner: Reviewed-by: Ashutosh Dixit > > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index fc03b74af..03d223df4 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -2447,7 +2447,7 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe, size_t oa_b > DRM_XE_OA_PROPERTY_OA_FORMAT, __ff(fmt), > DRM_XE_OA_PROPERTY_OA_PERIOD_EXPONENT, oa_exponent, > DRM_XE_OA_PROPERTY_OA_ENGINE_INSTANCE, hwe->engine_instance, > - DRM_XE_OA_PROPERTY_OA_BUFFER_SIZE, oa_buffer_size, > + DRM_XE_OA_PROPERTY_OA_BUFFER_SIZE, oa_buffer_size ?: buffer_fill_size > }; > struct intel_xe_oa_open_prop param = { > .num_properties = ARRAY_SIZE(properties) / 2, > @@ -4805,15 +4805,9 @@ igt_main > __for_one_hwe_in_oag(hwe) > test_buffer_fill(hwe); > > - igt_subtest_with_dynamic("non-zero-reason") { > - if (oau->capabilities & DRM_XE_OA_CAPS_OA_BUFFER_SIZE) { > - __for_one_hwe_in_oag_w_arg(hwe, "16M") > - test_non_zero_reason(hwe, SZ_16M); > - } else { > - __for_one_hwe_in_oag_w_arg(hwe, "default") > - test_non_zero_reason(hwe, 0); > - } > - } > + igt_subtest_with_dynamic("non-zero-reason") > + __for_one_hwe_in_oag(hwe) > + test_non_zero_reason(hwe, 0); > > igt_subtest("disabled-read-error") > test_disabled_read_error(); > -- > 2.34.1 >