From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19266C021B5 for ; Fri, 21 Feb 2025 17:08:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA8AD10EB04; Fri, 21 Feb 2025 17:08:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PXtVgkpZ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id B8F4E10EB04 for ; Fri, 21 Feb 2025 17:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740157735; x=1771693735; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=QGHI2ptL9dtS+LmLp2J7pSyE+P9JqNDQJ+/qbskBrqQ=; b=PXtVgkpZU6lKc5oZyP/6WU4ReJQUeVuAPLFg6+45nB3asLpHjWSpcUSa 9KUWwOl3knyiQHRpJnBeftc3CExF1fFBA3h2wMu1IqbRskSPnMBcMkO9N 2GXcWBm5HGzFLa0S5309argm+LyoOYLS5k9xEMGwU/K/l7sy26mVFkTgh 4LNAEj5+o9ETZtVNxAsq+AfUXy74h+OfSXrW8te1teYFHAh9TAO3WVxKq dypnOWY9gTyhdoRNs1RwFmfeLIv/EauXMBQiDQNETfW0d297crrgtKPje TpfJsuMOJuKFBpbxuGzC8kpVHbeSdbhDU3qzHLjccAtd/bBhoJJyp/myz g==; X-CSE-ConnectionGUID: XANJU/0GQBWT1ER09dfMuQ== X-CSE-MsgGUID: GdDK7O2jS92Lt2qeuB2KBQ== X-IronPort-AV: E=McAfee;i="6700,10204,11352"; a="63455454" X-IronPort-AV: E=Sophos;i="6.13,305,1732608000"; d="scan'208";a="63455454" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 09:08:19 -0800 X-CSE-ConnectionGUID: ofEprwUPQke27jK4/+Sp3A== X-CSE-MsgGUID: ZYOV8z37RuiCKbpx33Jvgg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="152615054" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 09:08:19 -0800 Date: Fri, 21 Feb 2025 09:08:18 -0800 Message-ID: <85ldtzns3h.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Marcin Bernatowicz Cc: , Jakub Kolakowski , Umesh Nerlige Ramappa Subject: Re: [PATCH i-g-t] tests/xe_oa: Skip when no OA units available In-Reply-To: <20250220130105.756157-1-marcin.bernatowicz@linux.intel.com> References: <20250220130105.756157-1-marcin.bernatowicz@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Thu, 20 Feb 2025 05:01:05 -0800, Marcin Bernatowicz wrote: > > Add a check to ensure at least one OA unit is available before > proceeding with the tests. This prevents unnecessary failures on > devices that do not support OA units. Are we seeing this anywhere? In any case: Acked-by: Ashutosh Dixit > > Signed-off-by: Marcin Bernatowicz > Cc: Ashutosh Dixit > Cc: Jakub Kolakowski > Cc: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 0242fd594..6abf44128 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -4852,6 +4852,7 @@ igt_main > > /* See xe_query_oa_units_new() */ > igt_require(xe_dev->oa_units); > + igt_require(xe_dev->oa_units->num_oa_units); > oau = nth_oa_unit(drm_fd, 0); > > devid = intel_get_drm_devid(drm_fd); > -- > 2.31.1 >