From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08E71CF34BB for ; Thu, 3 Oct 2024 16:57:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD39210E23C; Thu, 3 Oct 2024 16:57:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gyDF9tmm"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id F191210E23C for ; Thu, 3 Oct 2024 16:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727974629; x=1759510629; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=AQjfn/638c7JFBb/39zjRPUXYZLrn9+9uXcu8teOrAo=; b=gyDF9tmmjcU1ojJZFaRV0j2hhmSAEHn7UbusAYoXusC/4+ZxcZ1quwQF kwZaOXq9AcCgqjkm2BWwmbubEi1adWktZO8czb3FFQeuOhGmKWVr1Sxi+ plhUfB+VUcjBlp08r5xzZ4rNHdKdt0mj9sSJvr4OEJyQumFPEmv/l2+P2 mcamt/74tst/nK7Rmi9AMQ38RVW47B/KLVO94tK4QYL/jtNtQLGDHCCG0 RyHgGCsqKeQn5+Q6sKXWk5/nvu5kjJzpS2F7KHEZbj63RfvxRGhlB321i a03vcJc1/RPey3LmzioWQAxbsIMaCDO6vVUihGc861nZu7nIjOFFLBQBP A==; X-CSE-ConnectionGUID: VYzXCRl1SmeWbZFkIij6Rw== X-CSE-MsgGUID: BkPkSaRERQiDsJcca2TKzw== X-IronPort-AV: E=McAfee;i="6700,10204,11214"; a="44712888" X-IronPort-AV: E=Sophos;i="6.11,175,1725346800"; d="scan'208";a="44712888" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2024 09:57:08 -0700 X-CSE-ConnectionGUID: EDwWgRCnQdy0EcQez6dy1g== X-CSE-MsgGUID: Un2T3w+PSoy39iCdDIAq4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,175,1725346800"; d="scan'208";a="74851668" Received: from unknown (HELO orsosgc001.intel.com) ([10.165.21.138]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2024 09:57:08 -0700 Date: Thu, 03 Oct 2024 09:57:08 -0700 Message-ID: <85o7416s63.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Riana Tauro Cc: Soham Purkait , , Subject: Re: [PATCH i-g-t v2] tests/intel/xe_oa: Check gtidle before rc6 disable test In-Reply-To: <0d0cab70-0ba4-4c50-b7a9-ad580ee14db2@intel.com> References: <20241003115741.119720-1-soham.purkait@intel.com> <0d0cab70-0ba4-4c50-b7a9-ad580ee14db2@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Thu, 03 Oct 2024 05:25:18 -0700, Riana Tauro wrote: > Hi Soham > reword the subject > > On 10/3/2024 5:27 PM, Soham Purkait wrote: > > Rc6 disable test has been modified in order to check the > > presence of gtidle node in sysfs gt0 path through the following > > code snippets : > > igt_require(xe_sysfs_gt_has_node(drm_fd, 0, "gtidle")). > do not add code snippet in commit message Commit message should state the "why" of this patch, not described contents of the patch. "Why" meaning why is the patch needed or the reason it is being sent. > > > > As of now only Render GT (gt0) is used for rc6 disable test through OA > > activation. Standalone Media (gt1) is not supported yet for the same. > reword? > OA is supported only on render gt. This information looks irrelevant for the patch. It is also incorrect I think. > > add version history > > > > Signed-off-by: Soham Purkait > > --- > > tests/intel/xe_oa.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > > index 9be4fd633..6538d6323 100644 > > --- a/tests/intel/xe_oa.c > > +++ b/tests/intel/xe_oa.c > > @@ -4644,8 +4644,10 @@ igt_main > > test_oa_unit_concurrent_oa_buffer_read(); > > } > > - igt_subtest("rc6-disable") > > + igt_subtest("rc6-disable"){ > space before { Check tabs too (use tabs not spaces). > > Thanks, > Riana > > + igt_require(xe_sysfs_gt_has_node(drm_fd, 0, "gtidle")); Is this even possible? Why do we need to check this? > > test_rc6_disable(); > > + } > > igt_subtest_with_dynamic("stress-open-close") { > > __for_one_hwe_in_oag(hwe)