From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B21A9112750
 for <igt-dev@lists.freedesktop.org>; Mon,  8 Aug 2022 19:49:08 +0000 (UTC)
Date: Mon, 08 Aug 2022 12:49:07 -0700
Message-ID: <85pmha8qj0.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>
In-Reply-To: <b8fd14ff-681b-df11-ae6b-c9b859142571@quicinc.com>
References: <20220804220235.26076-1-quic_rohiiyer@quicinc.com>
 <20220804220235.26076-4-quic_rohiiyer@quicinc.com>
 <85r11q8wkn.wl-ashutosh.dixit@intel.com>
 <b8fd14ff-681b-df11-ae6b-c9b859142571@quicinc.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-7
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t v6 3/3] tests/kms_writeback: Enhance
 kms_writeback for custom modes
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org, quic_aravindh@quicinc.com,
 petri.latvala@intel.com
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 08 Aug 2022 10:41:50 -0700, Abhinav Kumar wrote:
>
> Hi Ashutosh
>
> On 8/8/2022 10:38 AM, Dixit, Ashutosh wrote:
> > On Thu, 04 Aug 2022 15:02:35 -0700, Rohith Iyer wrote:
> >>
> >>	igt_subtest("writeback-pixel-formats") {
> >> +		igt_skip_on(data.dump_check || data.list_modes);
> >>		drmModePropertyBlobRes *formats_blob =3D get_writeback_formats_blob(o=
utput);
> >>		const char *valid_chars =3D "01234568 ABCGNRUVXY";
> >>		unsigned int i;
> >
> > $ ninja -C build
> > ninja: Entering directory `build'
> > [120/1183] Compiling C object tests/kms_writeback.p/kms_writeback.c.o
> > ../tests/kms_writeback.c: In function =A1__igt_unique____real_main480=
=A2:
> > ../tests/kms_writeback.c:532:17: warning: ISO C90 forbids mixed declara=
tions and code [-Wdeclaration-after-statement]
> >    532 |                 drmModePropertyBlobRes *formats_blob =3D get_w=
riteback_formats_blob(output);
> >        |                 ^~~~~~~~~~~~~~~~~~~~~~
> > ../tests/kms_writeback.c:555:17: warning: ISO C90 forbids mixed declara=
tions and code [-Wdeclaration-after-statement]
> >    555 |                 igt_fb_t invalid_output_fb;
> >        |                 ^~~~~~~~
> > ../tests/kms_writeback.c:571:17: warning: ISO C90 forbids mixed declara=
tions and code [-Wdeclaration-after-statement]
> >    571 |                 igt_fb_t output_fb;
> >        |                 ^~~~~~~~
> > ../tests/kms_writeback.c:586:17: warning: ISO C90 forbids mixed declara=
tions and code [-Wdeclaration-after-statement]
> >    586 |                 igt_fb_t output_fb;
> >        |                 ^~~~~~~~
>
> All these warnings were pre-existing warnings in kms_writeback even before
> this series and not introduced by this series.

Hi Abhinav, doesn't seem to be the case, git blame:

    531 22fa5ae83a885 (Rohith Iyer                   2022-08-04 15:02:35 -0=
700 531)             igt_skip_on(data.dump_check || data.list

> However, we will be happy to fix these for the benefit of all.

Thanks, yes please fix.