From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 719D5C021AD for ; Tue, 18 Feb 2025 18:34:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 346CE10E02C; Tue, 18 Feb 2025 18:34:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="bGHjuRTd"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BF2510E02C for ; Tue, 18 Feb 2025 18:34:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739903694; x=1771439694; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=aEQcaCGvIqaF5zIawUS8rI35Z5dZpeiE0c6u/vRfX7E=; b=bGHjuRTdFuIJVfm91QKg1i3Ag/7d21oFYvl/YbP9CeKMJuJO/9J2qi2h Z9ISRT1TrS152beRLJTkjVJyQaW/44B13j6Wkqcn5KzyXxEp6DMz2BpcO RtkUikTUs0RNFa3vNg1mxOnxo7lc+BGIrOymiDw6yQTULJ/0764VyKAmF ftGLhL7hTmIsDGgSeNbaqjr20QxM750z7m7al9HckSJ1viW5hfIHaESSc T2Po55Bk6JYHadCrGgk236UrEiX6EGLLlPBW/ymbrGCtXxd0k1PoJDfPg gQ4S+2NXSCZmfYiRMyXa8aVAUfGU+l74fRhZaSmwEfnMYqovEy0/4VCdh w==; X-CSE-ConnectionGUID: DJGpZko8QEiKVx9hZU9iow== X-CSE-MsgGUID: P25h+1osRW+Ip7MzYafpHw== X-IronPort-AV: E=McAfee;i="6700,10204,11348"; a="51258707" X-IronPort-AV: E=Sophos;i="6.13,296,1732608000"; d="scan'208";a="51258707" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 10:34:54 -0800 X-CSE-ConnectionGUID: mFcuKDGsTWW3rC1AoXhBNg== X-CSE-MsgGUID: xZMBYz+mQbmWmkn/mmUZUQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="114334236" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 10:34:54 -0800 Date: Tue, 18 Feb 2025 10:34:53 -0800 Message-ID: <85seob14qa.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH 09/13] tests/intel/xe_oa: Test oa buffer sizes In-Reply-To: <20250215010628.1639986-10-umesh.nerlige.ramappa@intel.com> References: <20250215010628.1639986-1-umesh.nerlige.ramappa@intel.com> <20250215010628.1639986-10-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 14 Feb 2025 17:06:24 -0800, Umesh Nerlige Ramappa wrote: > > Introduce oa buffer size test separately. Pick a random valid buffer > size for the test. > > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 03d223df4..ee87b7338 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -93,6 +93,23 @@ struct accumulator { > uint64_t deltas[MAX_RAW_OA_COUNTERS]; > }; > > +struct oa_buf_size { > + char name[12]; > + uint32_t size; > +} buf_sizes[] = { > + { "128K", SZ_128K }, > + { "256K", SZ_256K }, > + { "512K", SZ_512K }, > + { "1M", SZ_1M }, > + { "2M", SZ_2M }, > + { "4M", SZ_4M }, > + { "8M", SZ_8M }, > + { "16M", SZ_16M }, > + { "32M", SZ_32M }, > + { "64M", SZ_64M }, > + { "128M", SZ_128M }, Would you have the running time for these? Hopefully not too huge for the large buffer sizes, even if we are running just one of them? And what about slower platforms? That was the reason we restricted OA buffer size to just 16 M. This is what I measured here: https://patchwork.freedesktop.org/patch/627269/?series=142128&rev=1 $ sudo ./build/tests/xe_oa --r oa-buffer-size IGT-Version: 1.29-g724fd0b79 (x86_64) (Linux: 6.12.0-rc4+ x86_64) Using IGT_SRANDOM=1733459091 for randomisation Opened device: /dev/dri/card0 Starting subtest: oa-buffer-size Starting dynamic subtest: 8MB Dynamic subtest 8MB: SUCCESS (0.403s) Starting dynamic subtest: 32MB Dynamic subtest 32MB: SUCCESS (1.595s) Starting dynamic subtest: 128MB Dynamic subtest 128MB: SUCCESS (6.326s) Subtest oa-buffer-size: SUCCESS (8.324s) > +}; > + > /* OA unit types */ > enum { > OAG, > @@ -305,6 +322,7 @@ static struct intel_mmio_data mmio_data; > static igt_render_copyfunc_t render_copy; > static uint32_t rc_width, rc_height; > static uint32_t buffer_fill_size; > +static uint32_t num_buf_sizes; > > static struct intel_xe_perf_metric_set *metric_set(const struct drm_xe_engine_class_instance *hwe) > { > @@ -1094,6 +1112,7 @@ init_sys_info(void) > rc_width = 1920; > rc_height = 1080; > buffer_fill_size = SZ_16M; > + num_buf_sizes = ARRAY_SIZE(buf_sizes); > oa_exponent_default = max_oa_exponent_for_period_lte(1000000); > > default_oa_buffer_size = get_default_oa_buffer_size(drm_fd); > @@ -4805,6 +4824,17 @@ igt_main > __for_one_hwe_in_oag(hwe) > test_buffer_fill(hwe); > > + /** > + * SUBTEST: buffer-size > + * Description: Test various OA buffer sizes > + */ > + igt_subtest_with_dynamic("buffer-size") { > + long k = random() % num_buf_sizes; > + > + __for_one_hwe_in_oag_w_arg(hwe, buf_sizes[k].name) > + test_non_zero_reason(hwe, buf_sizes[k].size); > + } > + > igt_subtest_with_dynamic("non-zero-reason") > __for_one_hwe_in_oag(hwe) > test_non_zero_reason(hwe, 0); > -- > 2.34.1 >