From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6C32C021AD for ; Tue, 18 Feb 2025 17:32:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 870A210E737; Tue, 18 Feb 2025 17:32:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="bYIUI+fH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74FE610E737 for ; Tue, 18 Feb 2025 17:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739899964; x=1771435964; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=5MedLxU+T50lF90GmtHoej8HKzI6qxpKqftLdEiXnvg=; b=bYIUI+fHRs/GV87vwnnly7TUH0TtZzgEOxYfX9wrz8xwXHhaFsAF34eF g27rpJsWdO4/GnKNoVb5VI2YGHBztpy7gyIUuE2ryf1S7+Iis6zF8lqQP KPgqA2h1yuAFIYRTD9A41JjIPyvPKVNz+CpXhQTE3wJ16xnh4z5zdp2K8 KGg2LunJDvOJtV1gaIIzKVT5QDu/1YBlwZ043qTq6N6aCi6TVLhnqWW1c fsW6XIugEUQqUAGTshyDI3NHOhCdgLg15DDm1E9SltutNuYcD/Q5s7YLE wDac2T106anLBlOPV7XHH44OsS6faxP2gL7E6aR2zvN+mYz5ihGawzXvt g==; X-CSE-ConnectionGUID: OO1ZJtToR7+irkiPh9M4gQ== X-CSE-MsgGUID: 7fDm4vhxR2SxRVwl/ICFug== X-IronPort-AV: E=McAfee;i="6700,10204,11348"; a="58009499" X-IronPort-AV: E=Sophos;i="6.13,296,1732608000"; d="scan'208";a="58009499" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 09:32:44 -0800 X-CSE-ConnectionGUID: NABuQyoHQymdUvvxjkle7Q== X-CSE-MsgGUID: m9IY3uGzSJu6tgjB+byq+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="151673175" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 09:32:43 -0800 Date: Tue, 18 Feb 2025 09:32:43 -0800 Message-ID: <85tt8r17lw.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH 02/13] tests/intel/xe_oa: Drop unused macro In-Reply-To: <20250215010628.1639986-3-umesh.nerlige.ramappa@intel.com> References: <20250215010628.1639986-1-umesh.nerlige.ramappa@intel.com> <20250215010628.1639986-3-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 14 Feb 2025 17:06:17 -0800, Umesh Nerlige Ramappa wrote: > > Drop unused for helper I don't remember why I left this in, probably wanted to save the way the macro was written. Anyway, we can get it out of git if we need it: Reviewed-by: Ashutosh Dixit > > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 3274d472d..9c74315df 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -4788,13 +4788,6 @@ static const char *xe_engine_class_name(uint32_t engine_class) > igt_dynamic_f("%s-%d-%s", xe_engine_class_name(hwe->engine_class), \ > hwe->engine_instance, str) > > -#define __for_one_render_engine_0(hwe) \ > - xe_for_each_engine(drm_fd, hwe) \ > - if (hwe->engine_class == DRM_XE_ENGINE_CLASS_RENDER) \ > - break; \ > - for_each_if(hwe->engine_class == DRM_XE_ENGINE_CLASS_RENDER) \ > - igt_dynamic_f("rcs-%d", hwe->engine_instance) > - > #define __for_one_render_engine(hwe) \ > for (int m = 0, done = 0; !done; m++) \ > for_each_if(m < xe_number_engines(drm_fd) && \ > -- > 2.34.1 >