From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 936EAC021AA for ; Tue, 18 Feb 2025 17:28:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5113510E737; Tue, 18 Feb 2025 17:28:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="euu/SPXx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C02310E737 for ; Tue, 18 Feb 2025 17:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739899697; x=1771435697; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=600ZaP/1QUGWJCY8nDFWx9sPTkJ+rJIpSIRZsGMTONw=; b=euu/SPXx94SjmOiHIth/vwsFSLKoQNI/jqjQHer6a11VvRQX8jneYNaK x88NgCj7Eop4hVtYur2MeHtoYhBiSiu+RBC4JhrggjuTooJ4XZOhAMRbP EqXWgkyhvNrzTe7MuuWQNzyoGQVbY/4Pib72zqtpcr60XEFoZbQbqEN6c pNZDMPyZ2g7eYwA0L9JGR19Bm0RTeWmLga8lxebRl06zAIRp2TJVI6eOr VBXPDNTSf009e8JT7uJXcbZBoL3248BYxBZ/1V4O6x6PbX7YMiXRkF8/L f6f4ptE1sVaZbPqHZ/I0XqjO+hHPLoj0bGKG3KpGHLTxfUSZYk/qbI6QJ w==; X-CSE-ConnectionGUID: OWU5eS/DQkGpDEsh3Mvr7g== X-CSE-MsgGUID: SVEG6m0lSaWwUHQQ0c+Dgg== X-IronPort-AV: E=McAfee;i="6700,10204,11348"; a="40748005" X-IronPort-AV: E=Sophos;i="6.13,296,1732608000"; d="scan'208";a="40748005" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 09:28:16 -0800 X-CSE-ConnectionGUID: Vm0x4LQUTreV82pAxtJyAA== X-CSE-MsgGUID: N5Li2OPeQy+KRMmayuz6jQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="114319639" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 09:28:17 -0800 Date: Tue, 18 Feb 2025 09:28:16 -0800 Message-ID: <85v7t717tb.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH 01/13] tests/intel/xe_oa: Use static for global variables In-Reply-To: <20250215010628.1639986-2-umesh.nerlige.ramappa@intel.com> References: <20250215010628.1639986-1-umesh.nerlige.ramappa@intel.com> <20250215010628.1639986-2-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 14 Feb 2025 17:06:16 -0800, Umesh Nerlige Ramappa wrote: > > Use static for mmio_data and hwe. > Reviewed-by: Ashutosh Dixit > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 0242fd594..3274d472d 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -296,12 +296,12 @@ static int pm_fd = -1; > static int stream_fd = -1; > static uint32_t devid; > > -struct drm_xe_engine_class_instance default_hwe; > +static struct drm_xe_engine_class_instance default_hwe; > > static struct intel_xe_perf *intel_xe_perf; > static uint64_t oa_exp_1_millisec; > static size_t default_oa_buffer_size; > -struct intel_mmio_data mmio_data; > +static struct intel_mmio_data mmio_data; > static igt_render_copyfunc_t render_copy; > > static struct intel_xe_perf_metric_set *metric_set(const struct drm_xe_engine_class_instance *hwe) > -- > 2.34.1 >