From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DC92C0218F for ; Fri, 31 Jan 2025 20:34:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DDC4310E19C; Fri, 31 Jan 2025 20:34:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SpnQ0Sh5"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 195C510E19C for ; Fri, 31 Jan 2025 20:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738355672; x=1769891672; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=6QVtkc02dkA655ntA0XGSJKktqKyWx6kAu09TzdAmUQ=; b=SpnQ0Sh5fwCn0HhCtIPUrnpWhXmD6IcDCqtwcy6YN3o2mx/YqZA8FwKE Vb2T3hxXrF2AtEHjNCL9diXHpQSEpiF3k68eByveWlw0uaLViVl3Jr1Ms /Rq2uZKjvT+kYqhGkbxvLfT6oaObzPUtJcCmKvFfPDjgCUcbRGl7m5pux Xu9aqUW6BO8p2p8XEWsI9NuP9A0UVlU+e2aOikkkNPSgXfpZa+BCwSFWD JK1Qyvm44DKYn8Bx1fJO5JAllWnw1q4rr9Gh4BSsjF0FDzHznofPmKX9u siDUDN9VjCwWe73l8dvkAh9R5joUt8H95Ex1xpU5QPdcKKJzcpXTFiFgw g==; X-CSE-ConnectionGUID: OpDT3GGqRZq5P7UTAc8k4Q== X-CSE-MsgGUID: hC/tl0pxRqOb80a7GdO/uQ== X-IronPort-AV: E=McAfee;i="6700,10204,11332"; a="64294866" X-IronPort-AV: E=Sophos;i="6.13,249,1732608000"; d="scan'208";a="64294866" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2025 12:34:31 -0800 X-CSE-ConnectionGUID: w30ip2rPT2KHQvlCSI+ubQ== X-CSE-MsgGUID: RUY6nJNSSgusSRJZA1mRZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,249,1732608000"; d="scan'208";a="140606964" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2025 12:34:31 -0800 Date: Fri, 31 Jan 2025 12:34:31 -0800 Message-ID: <85v7tuen8o.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH i-g-t 1/2] lib/xe/oa: Add observation type input to intel_xe_perf_ioctl and intel_xe_perf_ioctl_err In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 31 Dec 2024 01:46:28 -0800, Harish Chegondi wrote: > > In order to reuse intel_xe_perf_ioctl() and intel_xe_perf_ioctl_err() > functions for EU stall sampling, add observation type as an input > parameter to these functions and set the input observation type to > observation_type in struct drm_xe_observation_param. > > Signed-off-by: Harish Chegondi > --- > lib/xe/xe_oa.c | 18 +++++++--- > lib/xe/xe_oa.h | 11 ++++-- > tests/intel/xe_oa.c | 57 +++++++++++++++++++++----------- > tools/xe-perf/xe_perf_configs.c | 2 +- > tools/xe-perf/xe_perf_recorder.c | 3 +- Why would EU stall want to use functions from lib/xe/xe_oa.c, which is a library specific to OA. Why don't you just copy these functions into tests/intel/xe_eu_stall.c stall, rename them and use them? The functions are in the library for OA because of use by other OA/perf tools, they are not meant for use by EU stall. So this is a NAK on this patch. Ashutosh