From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADAA9D7879A for ; Thu, 21 Nov 2024 17:13:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B02010E9F4; Thu, 21 Nov 2024 17:13:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="VIUe5LpS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id D539A10E9F4 for ; Thu, 21 Nov 2024 17:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732209235; x=1763745235; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=/6RqJZLsOb5QiEnjzrfakB9rDiR0qZEWim+LIvRcDhw=; b=VIUe5LpS/582t3JD1pvA3ta/eisisSVtesCpAM6cDzhUaTgEZp4LP8Fs gWJp8gqgmHU3cNeEInDFtxGL+o0S9bQzSr2mHKy2EP6mco9muykNXuag+ CJjU6eFcBXkq5ajovU58PPUbB63GztYi5x0iSnFXa8+CWTN/CPPb0jqX3 LB4RwoBP/1Mcac6bIiKX8WStWkyK2ZX/KN8tu3w8NHIotU1HbzQB5fRd/ CeODaH2x6o5WdbU5rTN+y7GSxGcC1VXGiYwfn1irkhmaq/iNr4smf6lTv ZuMJDidbaYwlIH/cKrn9d+D6Ush4Ax2qQDogn0KTmzZOHSJEtjCfaSdFC g==; X-CSE-ConnectionGUID: V2EUZOtBS620q13fekLuug== X-CSE-MsgGUID: DXvrDm6wSye+3Ig/Tx6H+w== X-IronPort-AV: E=McAfee;i="6700,10204,11263"; a="32269104" X-IronPort-AV: E=Sophos;i="6.12,173,1728975600"; d="scan'208";a="32269104" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2024 09:13:55 -0800 X-CSE-ConnectionGUID: aHU3FWOcRwOsLvSGrLe7Ww== X-CSE-MsgGUID: b0v4OY/fQsGgw8oPq+6Fcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,173,1728975600"; d="scan'208";a="94760222" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2024 09:13:55 -0800 Date: Thu, 21 Nov 2024 09:13:54 -0800 Message-ID: <85wmgwjyr1.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Sai Teja Pottumuttu Cc: Subject: Re: [PATCH i-g-t v2 1/1] tests/intel/xe_oa: Fetch OA buffer size from observation IOCTL In-Reply-To: <85zflu6c24.wl-ashutosh.dixit@intel.com> References: <20241119090405.951437-1-sai.teja.pottumuttu@intel.com> <20241119090405.951437-2-sai.teja.pottumuttu@intel.com> <85zflu6c24.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 19 Nov 2024 15:25:39 -0800, Dixit, Ashutosh wrote: > > On Tue, 19 Nov 2024 01:04:05 -0800, Sai Teja Pottumuttu wrote: > > > > Currently, the OA buffer size is hardcoded to 16MB in IGT. The patch > > refactors it to get the default oa buffer size using > > DRM_XE_OBSERVATION_IOCTL_INFO ioctl. This way if we decide to increase > > the default OA buffer size, it wouldn't need IGT modification every time. > > > > v2: > > - Rename the oa_buffer_size global variable [Ashutosh] > > - Use size_t instead of u64 [Ashutosh] > > Looks good now: > > Reviewed-by: Ashutosh Dixit > > I will merge this after CI completes. Thanks for the patch :) Merged!