From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34BBCD591B2 for ; Mon, 18 Nov 2024 20:03:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EBC7A10E171; Mon, 18 Nov 2024 20:03:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="P6u1UTW5"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 932B810E171 for ; Mon, 18 Nov 2024 20:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731960202; x=1763496202; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Y0VbhnxHdhg/vRsSQhHqw4fZbwtTOjZ9GTDuRiTdhL0=; b=P6u1UTW5I7Qg84LOlvs6vKS2pD1rphxsu+bj7tL76WdsZhhHRiayuCQI i3Yeh+8PJIsQhFQJssp2ovPlCtcSUX77GkfaHw/bczLMRiX5wdWWHBKMY jfGyHpLSjWiYOWoBArXBVOw3dKDiRLKaxK1xrIzc+ldX0RbunPjPA5baz U4rgGBJU0+/+VPU1i2hctYwGIScNhBKF1XovQNp40qGgQOmaKzLkrcdLV AiuSeiTNP2NQdRjiXC05JxpeBmUl/KhngjNdlORAlQQwrq7cX6/yYKDhN Q6hPzxr/8zd4m6kQHUgIgRL8wMmG3fGHryKFJb2SCCnuHFykaF+Dqt/Ht g==; X-CSE-ConnectionGUID: /P4xkAMRROa1YLoYzUg4Ig== X-CSE-MsgGUID: qhOIObKmTNSF+vyw038IMA== X-IronPort-AV: E=McAfee;i="6700,10204,11260"; a="49369440" X-IronPort-AV: E=Sophos;i="6.12,164,1728975600"; d="scan'208";a="49369440" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2024 12:03:21 -0800 X-CSE-ConnectionGUID: jXtkNcRSRFqC5TYcu90RLw== X-CSE-MsgGUID: P8na3iqYT8y2k9wKiTU6Vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,164,1728975600"; d="scan'208";a="126866849" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2024 12:03:21 -0800 Date: Mon, 18 Nov 2024 12:03:20 -0800 Message-ID: <85wmh0wbqv.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Sai Teja Pottumuttu Cc: Subject: Re: [PATCH i-g-t 1/2] tests/intel/xe_oa: Fetch OA buffer size from observation IOCTL In-Reply-To: <20241118063223.3974722-2-sai.teja.pottumuttu@intel.com> References: <20241118063223.3974722-1-sai.teja.pottumuttu@intel.com> <20241118063223.3974722-2-sai.teja.pottumuttu@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Sun, 17 Nov 2024 22:32:22 -0800, Sai Teja Pottumuttu wrote: > > @@ -2367,7 +2392,7 @@ test_buffer_fill(const struct drm_xe_engine_class_instance *hwe) > int buf_size = 65536 * report_size; > uint8_t *buf = malloc(buf_size); > int len; > - size_t oa_buf_size = MAX_OA_BUF_SIZE; > + size_t oa_buf_size = oa_buffer_size; > int n_full_oa_reports = oa_buf_size / report_size; > uint64_t fill_duration = n_full_oa_reports * oa_period; > uint32_t *last_periodic_report = malloc(report_size); > @@ -2592,7 +2617,7 @@ test_enable_disable(const struct drm_xe_engine_class_instance *hwe) > size_t report_size = get_oa_format(fmt).size; > int buf_size = 65536 * report_size; > uint8_t *buf = malloc(buf_size); > - size_t oa_buf_size = MAX_OA_BUF_SIZE; > + size_t oa_buf_size = oa_buffer_size; > int n_full_oa_reports = oa_buf_size / report_size; > uint64_t fill_duration = n_full_oa_reports * oa_period; > uint32_t *last_periodic_report = malloc(report_size); Maybe get rid of these two oa_buf_size local variables too, directly use default_oa_buffer_size.