From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E41AFC48260 for ; Tue, 13 Feb 2024 05:24:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D3C010E112; Tue, 13 Feb 2024 05:24:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ediJaCae"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43B5410E112 for ; Tue, 13 Feb 2024 05:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707801860; x=1739337860; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=5oXE3xyetZYHOtmj/pG+FuKTC7y5yQ8OSuF9wN/UvkU=; b=ediJaCaeg+tht7GAN/vnatKGMA4X1gRc3M83PMdAheYC7jq8oy7Wj7db S/powwQe3JcJocST9xMVy83gfDJF1SDPDFiqRCMEbrdqoKhhpxPMpZGLL T9IVoLcItK1WWhn7JjPQZRQxhdE4sC47JhgJYT7YBL7ClDBLIcSu9/Pwh AuzpaZcLLolJRP+HvALkqf4swW8OwyK7RM7BxwBZ27xI2zJzrJboZV2sO 3b7FpjsUMQh5XPdevWLjSIfHu2JpTy7WCoB1V4MbryjSptEGEEXGln8Pp dai8gy97B9nyqfMe+58uHSa0vR4/aaS9PP3/+cYPY/+vIHChbFONFbq5d A==; X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="396232567" X-IronPort-AV: E=Sophos;i="6.06,156,1705392000"; d="scan'208";a="396232567" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 21:24:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,156,1705392000"; d="scan'208";a="2750007" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 21:24:19 -0800 Date: Mon, 12 Feb 2024 21:24:18 -0800 Message-ID: <85wmr9uebh.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Borah, Chaitanya Kumar" Cc: "igt-dev@lists.freedesktop.org" , "Nerlige\ Ramappa, Umesh" , "Kalvala, Haridhar" Subject: Re: [PATCH i-g-t] lib: Add ARL-S PCI ID for perf tests In-Reply-To: References: <20240205060139.3643855-1-chaitanya.kumar.borah@intel.com> <85a5oec1ek.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 05 Feb 2024 22:25:49 -0800, Borah, Chaitanya Kumar wrote: > > Hello Ashutosh, > > > -----Original Message----- > > From: Dixit, Ashutosh > > Sent: Monday, February 5, 2024 10:08 PM > > To: Borah, Chaitanya Kumar > > Cc: igt-dev@lists.freedesktop.org; Nerlige Ramappa, Umesh > > > > Subject: Re: [PATCH i-g-t] lib: Add ARL-S PCI ID for perf tests > > > > On Sun, 04 Feb 2024 22:01:39 -0800, Chaitanya Kumar Borah wrote: > > > > > > > Hi Chaitanya, > > > > > Enable perf tests on ARL-S > > > > > > Signed-off-by: Chaitanya Kumar Borah > > > --- > > > lib/i915_pciids_local.h | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/lib/i915_pciids_local.h b/lib/i915_pciids_local.h index > > > a0ca29ee7..0043b0cd9 100644 > > > --- a/lib/i915_pciids_local.h > > > +++ b/lib/i915_pciids_local.h > > > @@ -10,7 +10,8 @@ > > > /* MTL perf */ > > > #ifndef INTEL_MTL_M_IDS > > > #define INTEL_MTL_M_IDS(info) \ > > > - INTEL_VGA_DEVICE(0x7D60, info) > > > + INTEL_VGA_DEVICE(0x7D60, info), \ > > > + INTEL_VGA_DEVICE(0x7D67, info) > > > > 1. Did you check if this fixes the OA tests on ARL? Or this will enable > > the testing? > > > > Yes, we verified locally. After the PCI-ID is added the perf tests are executing successfully. > > > 2. Why not include all ARL PCI ID's? Seem to be already there in kernel > > include/drm/i915_pciids.h. Also: > > > > https://gfxspecs.intel.com/Predator/Home/Index/55420 > > > > I was looking at it from only ARL-S perspective. > +Haridhar is looking into ARL-H. > > > 3. How about moving all these MTL/ARL ID's into lib/i915_pciids.h from > > lib/i915_pciids_local.h? > > > > The perf test needs differentiations between PCI-IDs that lib/i915_pciids.h does not provide. Therefore we maintain separate macros in lib/i915_pciids_local.h. > > Please refer to the conversation here. > > https://lore.kernel.org/all/7297abc4-309a-4ca8-a606-498b3abd0c2a@intel.com/ Reviewed-by: Ashutosh Dixit