From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8DC9D6C2B7 for ; Tue, 19 Nov 2024 23:25:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9733010E06C; Tue, 19 Nov 2024 23:25:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CKVYv9s5"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2888610E06C for ; Tue, 19 Nov 2024 23:25:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732058740; x=1763594740; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=OWW8Bdl3n9A9vhY0YA2u/of+56W+uHHj4fC8XYlwrGQ=; b=CKVYv9s50Gz66Qjc/JXnvWVNwZMzEpNmmI8f3aAwtwqSopj4tZQ3Ryas I5llAU5JjZ41x3LmBLxvck3jSWoVmoLFCfCHFqEJFlDlWPrqqMVJohzhO Qy2JtfhD0qv/3Qm9IUMS9MrQ3PZ/tpvQxOaDlbIXfojLVLNu+wZjFQ2my 5efTSo5uDSRbqet/hdq2zBmxuMzwKqEAVT+StRW7DJxd+jlaqzrglsU0r 7h/8B5h2HaoB7B6yOzLW3QEs0EH/ed1n/juBZO66TBGcDqDeLwdj76yv1 KIvvOYofcacVW0H7/t9zDa4lNO9xlWVhwgp2V5c8mHf8zFO4DnnGOROjn w==; X-CSE-ConnectionGUID: jHBQZ1RhQW+ZGhdi8p+PAw== X-CSE-MsgGUID: 9tom6UBtTBmBb1BKm+tBCQ== X-IronPort-AV: E=McAfee;i="6700,10204,11261"; a="32197982" X-IronPort-AV: E=Sophos;i="6.12,168,1728975600"; d="scan'208";a="32197982" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2024 15:25:39 -0800 X-CSE-ConnectionGUID: 85O+OZfYSmWzUZMB0dbZUA== X-CSE-MsgGUID: rG+yzZflRmWRCD2mq6WXig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="94778506" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2024 15:25:39 -0800 Date: Tue, 19 Nov 2024 15:25:39 -0800 Message-ID: <85zflu6c24.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Sai Teja Pottumuttu Cc: Subject: Re: [PATCH i-g-t v2 1/1] tests/intel/xe_oa: Fetch OA buffer size from observation IOCTL In-Reply-To: <20241119090405.951437-2-sai.teja.pottumuttu@intel.com> References: <20241119090405.951437-1-sai.teja.pottumuttu@intel.com> <20241119090405.951437-2-sai.teja.pottumuttu@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 19 Nov 2024 01:04:05 -0800, Sai Teja Pottumuttu wrote: > > Currently, the OA buffer size is hardcoded to 16MB in IGT. The patch > refactors it to get the default oa buffer size using > DRM_XE_OBSERVATION_IOCTL_INFO ioctl. This way if we decide to increase > the default OA buffer size, it wouldn't need IGT modification every time. > > v2: > - Rename the oa_buffer_size global variable [Ashutosh] > - Use size_t instead of u64 [Ashutosh] Looks good now: Reviewed-by: Ashutosh Dixit I will merge this after CI completes. Thanks for the patch :)