From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Naladala, Ramanaidu" <ramanaidu.naladala@intel.com>
Subject: Re: [PATCH i-g-t v3 2/2] lib/igt_psr: Fix PR state check for DisplayPort connectors
Date: Wed, 18 Sep 2024 07:36:13 +0000 [thread overview]
Message-ID: <864cdc02b98299644469540a39ed2fa3ac583b29.camel@intel.com> (raw)
In-Reply-To: <20240911202408.1665929-3-ramanaidu.naladala@intel.com>
On Thu, 2024-09-12 at 01:54 +0530, Naladala Ramanaidu wrote:
> The PR state check logic has been updated to handle DisplayPort
> connectors.
>
> v1: Update connecter logic for PR tests.
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> lib/igt_psr.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index 222e05e6c..99f08f3c2 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -77,12 +77,11 @@ static bool psr_active_check(int debugfs_fd, enum
> psr_mode mode, igt_output_t *o
> if (mode == PR_MODE || mode == PR_MODE_SEL_FETCH) {
> igt_assert_f(output, "Output not given\n");
> c = output->config.connector;
> - }
> -
> - if ((mode == PR_MODE || mode == PR_MODE_SEL_FETCH) &&
> - c && c->connector_type == DRM_MODE_CONNECTOR_eDP)
> - state = "SLEEP";
> - else if (mode == PSR_MODE_1 || mode == PR_MODE || mode ==
> PR_MODE_SEL_FETCH)
> + if (c->connector_type ==
> DRM_MODE_CONNECTOR_DisplayPort)
> + state = "SRDENT_ON";
> + else if (c->connector_type == DRM_MODE_CONNECTOR_eDP)
> + state = "SLEEP";
> + } else if (mode == PSR_MODE_1)
> state = "SRDENT";
> else if (mode == PSR_MODE_2 || mode == PSR_MODE_2_SEL_FETCH)
> state = "DEEP_SLEEP";
next prev parent reply other threads:[~2024-09-18 7:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 20:24 [PATCH i-g-t v3 0/2] tests/intel/kms_psr: DP2.1 PR IGT Fixes Naladala Ramanaidu
2024-09-11 20:24 ` [PATCH i-g-t v3 1/2] lib/igt_psr: Remove SRD status change check for DP2.1 Panel Replay Naladala Ramanaidu
2024-09-18 7:35 ` Hogander, Jouni
2024-09-11 20:24 ` [PATCH i-g-t v3 2/2] lib/igt_psr: Fix PR state check for DisplayPort connectors Naladala Ramanaidu
2024-09-18 7:36 ` Hogander, Jouni [this message]
2024-09-12 6:47 ` ✗ GitLab.Pipeline: warning for tests/intel/kms_psr: DP2.1 PR IGT Fixes (rev4) Patchwork
2024-09-12 7:10 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-12 7:15 ` ✗ CI.xeBAT: failure " Patchwork
2024-09-12 12:39 ` ✓ CI.xeFULL: success " Patchwork
2024-09-12 12:40 ` ✓ CI.xeBAT: success for tests/intel/kms_psr: DP2.1 PR IGT Fixes (rev5) Patchwork
2024-09-12 12:46 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-09-12 20:26 ` ✗ CI.xeFULL: " Patchwork
2024-09-19 8:04 ` Naladala, Ramanaidu
2024-09-13 0:13 ` ✗ Fi.CI.IGT: failure for tests/intel/kms_psr: DP2.1 PR IGT Fixes (rev4) Patchwork
2024-09-19 4:41 ` ✓ Fi.CI.BAT: success for tests/intel/kms_psr: DP2.1 PR IGT Fixes (rev5) Patchwork
2024-09-19 15:29 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864cdc02b98299644469540a39ed2fa3ac583b29.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox