From: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
"Wentland, Harry" <Harry.Wentland@amd.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] amdpgu/amd_bypass: Drop unneeded includes
Date: Fri, 28 Jun 2019 12:10:27 +0000 [thread overview]
Message-ID: <86de55b2-f73f-2bce-eb7f-e4027e2701df@amd.com> (raw)
In-Reply-To: <20190628101857.wrh3xoe5ajeck3bb@ahiler-desk1.fi.intel.com>
On 6/28/19 6:18 AM, Arkadiusz Hiler wrote:
> On Thu, Jun 27, 2019 at 06:19:14PM +0000, Harry Wentland wrote:
>> On 2019-06-27 1:34 p.m., Nicholas Kazlauskas wrote:
>>> These just break the build on debian-mason-arm and debian-meson-mips
>>> and aren't needed in the first place.
>>>
>>> Cc: Dingchen Zhang <dingchen.zhang@amd.com>
>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>>
>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>>
>> Harry
>
> Thanks for swift fix. Starting next week pre-merge gitlab pipelines are
> going to send emails on errors, so it should be easier to catch such
> breakages early.
>
> Now you can check them from patchwork.
>
> https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/385512
>
> This still fails the meson-autotools testlist consistency check. Expect
> patch in 5 :-)
>
Thank you for the follow up patch!
I just noticed the pre-merge pipeline on this change on patchwork, so I
guess this is a recent addition. These will be really useful for
catching these errors during review.
Nicholas Kazlauskas
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-28 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 17:34 [igt-dev] [PATCH i-g-t] amdpgu/amd_bypass: Drop unneeded includes Nicholas Kazlauskas
2019-06-27 18:19 ` Harry Wentland
2019-06-28 10:18 ` Arkadiusz Hiler
2019-06-28 12:10 ` Kazlauskas, Nicholas [this message]
2019-06-28 8:49 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-28 16:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86de55b2-f73f-2bce-eb7f-e4027e2701df@amd.com \
--to=nicholas.kazlauskas@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox