From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0213410E476 for ; Sat, 20 May 2023 00:25:52 +0000 (UTC) Date: Fri, 19 May 2023 17:21:42 -0700 Message-ID: <871qjbx36x.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , igt-dev@lists.freedesktop.org, Ashutosh Dixit , Riana Tauro , Zbigniew Kempczynski , Umesh Nerlige Ramappa , vikas.srivastava@intel.com In-Reply-To: <20230519124525.uw3aqwjge6i65rpg@kamilkon-desk1> References: <20230519083049.3739356-1-ashutosh.dixit@intel.com> <20230519124525.uw3aqwjge6i65rpg@kamilkon-desk1> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_engine_topology: Support gem_list_engines on platforms prior to MTL List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, 19 May 2023 05:45:25 -0700, Kamil Konieczny wrote: > Hi Kamil, > > On 2023-05-19 at 01:30:49 -0700, Ashutosh Dixit wrote: > > gem_list_engines() should list engines correctly on platforms prior to > > MTL. But at present it doesn't, it only supports MTL, and it skips on the > ----------------------------------------------------- ^ > s/, and/ and/ > > > 'igt_require(IS_METEORLAKE)' check for prior platforms. Fix this by > -- ^ > > imho better: > s/skips on the ... prior platforms/skips on other platforms/ > > > modifying gem_engine_to_gt_map() to return gt 0 for prior platforms, > > because the only multi-gt platform supported at present in MTL. > --------------------------------------------------------- ^ > s/in/is/ I will fix up the comments before merging. > We do support multi-gpu, for example two or more DG2 or ATS-M cards ? Thanks for reviewing, but I don't understand this question. All this gem_list_engines stuff is used for listing the engines for a gt (and for a class), so it's all within a single gpu (see e.g. intel_ctx_create_for_gt()). Multiple devices is a separate issue. But may be I am misunderstanding? > > > > > Fixes: d2f39ce8186a ("lib/i915/gem_engine_topology: list engines specific to gt") > > Signed-off-by: Ashutosh Dixit > > Reviewed-by: Kamil Konieczny Thanks. -- Ashutosh > > Regards, > Kamil > > > --- > > lib/i915/gem_engine_topology.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c > > index 6c8929ec591a..7c6cd9ba97db 100644 > > --- a/lib/i915/gem_engine_topology.c > > +++ b/lib/i915/gem_engine_topology.c > > @@ -372,8 +372,12 @@ mtl_engine_to_gt_map(const struct i915_engine_class_instance *e) > > > > static int gem_engine_to_gt_map(int i915, const struct i915_engine_class_instance *engine) > > { > > - igt_require(IS_METEORLAKE(intel_get_drm_devid(i915))); > > - return mtl_engine_to_gt_map(engine); > > + uint32_t devid = intel_get_drm_devid(i915); > > + > > + /* Only MTL multi-gt supported at present */ > > + igt_require(intel_graphics_ver(devid) <= IP_VER(12, 70)); > > + > > + return IS_METEORLAKE(devid) ? mtl_engine_to_gt_map(engine) : 0; > > } > > > > /** > > -- > > 2.38.0 > >