From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 625C310E315
 for <igt-dev@lists.freedesktop.org>; Tue, 29 Mar 2022 20:50:23 +0000 (UTC)
Date: Tue, 29 Mar 2022 13:50:22 -0700
Message-ID: <871qyka3g1.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
In-Reply-To: <20220328101339.136706-1-riana.tauro@intel.com>
References: <20220328064722.127301-2-riana.tauro@intel.com>
 <20220328101339.136706-1-riana.tauro@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t v3 1/2] tests/i915/i915_suspend: Add
 system-suspend-without-i915 subtest
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 28 Mar 2022 03:13:39 -0700, Riana Tauro wrote:
>
> From: "Tauro, Riana" <riana.tauro@intel.com>
>
> Add a new subtest system-suspend-without-i915 to exercise suspend/resume cycle
> without i915 module to know the system wide health of suspend/resume feature.
> This test will be part of CI fast-feedback test list.
>
> v2:
> -Remove drm_cancel_work_at_exit.
> -Add igt_describe. [Anshuman]
>
> v3 : Added assertion on unload module.[Anshuman]

No need to use a period after these small comments, they look weird. Period
at the end of longer comments are fine. Please look at 'git log' for
examples.

> @@ -202,10 +203,26 @@ test_forcewake(int fd, bool hibernate)
>	close (fw_fd);
>  }
>
> +static void
> +test_suspend_without_i915(void)
> +{
> +	igt_kmsg(KMSG_INFO "Unloading i915\n");
> +	igt_assert_eq(igt_i915_driver_unload(),0);
> +
> +	igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);

Do we need any other suspend/resume tests without i915 or just this is
sufficient? Anyway this is fine for now, we can add more if needed later.