From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F0336EA02 for ; Wed, 13 Oct 2021 00:44:43 +0000 (UTC) Date: Tue, 12 Oct 2021 17:44:42 -0700 Message-ID: <871r4pkb2d.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20211011071332.18492-1-arjun.melkaveri@intel.com> References: <20211011071332.18492-1-arjun.melkaveri@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_bad_reloc: Added check for verifying aperture support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Arjun Melkaveri Cc: igt-dev@lists.freedesktop.org List-ID: On Mon, 11 Oct 2021 00:13:32 -0700, Arjun Melkaveri wrote: > > Added check for verifying aperture support. > "negative_reloc" subtest uses gtt address spaze size This is calling gem_aperture_size() which is a I915_CONTEXT_PARAM_GTT_SIZE which seems to be the per context VM size not the GGTT size. Look at the i915 code. > and "negative_reloc_blt" uses fences, which needs aperture support. This again looks like fences will only be used if the object is tiled which doesn't seem to be in this case? > This would avoid test failure for platfom that doesnt support this. Where are we saying failures? Is there a bug? > diff --git a/tests/i915/gem_bad_reloc.c b/tests/i915/gem_bad_reloc.c > index 3ca0f345..d0902e6c 100644 > --- a/tests/i915/gem_bad_reloc.c > +++ b/tests/i915/gem_bad_reloc.c > @@ -195,6 +195,7 @@ igt_main > /* Check if relocations supported by platform */ > igt_require(gem_has_relocations(fd)); > gem_require_blitter(fd); > + gem_require_mappable_ggtt(fd);