From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 8D63589AB5
 for <igt-dev@lists.freedesktop.org>; Mon, 30 Aug 2021 18:56:32 +0000 (UTC)
Date: Mon, 30 Aug 2021 11:43:00 -0700
Message-ID: <871r6awz7v.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20210829201559.656-1-arjun.melkaveri@intel.com>
References: <20210829201559.656-1-arjun.melkaveri@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Resolve
 missing context for independent subtest
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Arjun Melkaveri <arjun.melkaveri@intel.com>
Cc: igt-dev@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

On Sun, 29 Aug 2021 13:15:59 -0700, Arjun Melkaveri wrote:
>
> @@ -380,22 +381,24 @@ static void independent(int fd, const intel_ctx_t *ctx, unsigned int engine,
>		if (!gem_class_can_store_dword(fd, e->class))
>			continue;
>
> +		tmp_ctx = intel_ctx_create(fd, &ctx->cfg);
>		if (spin == NULL) {
>			spin = __igt_spin_new(fd,
>					      .ahnd = ahnd,
> -					      .ctx = ctx,
> +					      .ctx = tmp_ctx,
>					      .engine = e->flags,
>					      .flags = flags);
>		} else {
>			struct drm_i915_gem_execbuffer2 eb = {
>				.buffer_count = 1,
>				.buffers_ptr = to_user_pointer(&spin->obj[IGT_SPIN_BATCH]),
> +				.rsvd1 = tmp_ctx->id,

.rsvd1 is definitely missing which should explain the assert for
gem_execbuf, but looks like we should not need a new "tmp_ctx" but should
be able to submit against the original "ctx", so all we need is:

				.rsvd1 = ctx->id,