From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id EAD366E4A6 for ; Wed, 12 Feb 2020 00:17:30 +0000 (UTC) Date: Tue, 11 Feb 2020 16:17:28 -0800 Message-ID: <871rr0wtev.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20200211023108.25369-4-imre.deak@intel.com> References: <20200211023108.25369-1-imre.deak@intel.com> <20200211023108.25369-4-imre.deak@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH v2 4/8] tests/kms_draw_crc: Skip GTT subtests on platforms w/o aperture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Imre Deak Cc: igt-dev@lists.freedesktop.org List-ID: On Mon, 10 Feb 2020 18:31:04 -0800, Imre Deak wrote: > > Subtests drawing through a GTT mapping are not relevant on platforms w/o > a GTT aperture, so skip them. > > Cc: Matt Roper > Signed-off-by: Imre Deak > Reviewed-by: Matt Roper > --- > tests/kms_draw_crc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/kms_draw_crc.c b/tests/kms_draw_crc.c > index ea14db9a..6de9feae 100644 > --- a/tests/kms_draw_crc.c > +++ b/tests/kms_draw_crc.c > @@ -178,6 +178,8 @@ static void draw_method_subtest(enum igt_draw_method method, > igt_crc_t crc; > > igt_skip_on(method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd)); > + igt_skip_on(method == IGT_DRAW_MMAP_GTT && > + !gem_has_mappable_ggtt(drm_fd)); Can't we add the skip directly in draw_rect_mmap_gtt() so we don't have to go skip in each individual test which ends up calling draw_rect_mmap_gtt()? _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev