From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CDDBCD37B1 for ; Tue, 3 Sep 2024 21:06:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1487310E1B8; Tue, 3 Sep 2024 21:06:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="RAPqS1MO"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B40310E1B8 for ; Tue, 3 Sep 2024 21:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725397585; x=1756933585; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Q6lfY92FHiNj3LVwvW/FfojmXa0SIqSyr6bJKcC//a0=; b=RAPqS1MO1LYuVLMGTBluJDux8WEkax296OvnnA0uT+A+/YxJNzC4TlFJ ODytfL24DFliRC8CHMj23M/ljjP5tRlr/bxS2glUcKPuAI8m52JifKh4v 9xGTJ0JqWiuSc8jNZo0Qrjg8pZFLh/s2Qy51V6jpfx3SAe9V+LUpSldlc UayKEs7HyoBqdnPvxs6Vhc8ozM6Y6lm6RwsQLKphcrI1BqFkQO1fGgZKs RUrHIbR9Wt5Hul9PXnBufGJeVFmltjxorFX9VEa5GhgMt6WT0B9tm1nMY qaGWeFSV3C+EDItetasAcH8uAj2C8zFC7AOaORXP9sgJSwm9HWBKlLi7V w==; X-CSE-ConnectionGUID: ghjxtbLWTTWhaiAW3jMj4Q== X-CSE-MsgGUID: y7WEF8V/TceHOaVi0rS5kA== X-IronPort-AV: E=McAfee;i="6700,10204,11184"; a="13354368" X-IronPort-AV: E=Sophos;i="6.10,199,1719903600"; d="scan'208";a="13354368" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2024 14:06:24 -0700 X-CSE-ConnectionGUID: sgifm/j1S0eVmifeJQ2sDg== X-CSE-MsgGUID: O7xQmiX6RbakzSUAF4JvvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,199,1719903600"; d="scan'208";a="95776630" Received: from jtuanzol-mobl2.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.129.72]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2024 14:06:23 -0700 Date: Tue, 03 Sep 2024 13:55:38 -0700 Message-ID: <8734mgzcc5.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jani Nikula Cc: igt-dev@lists.freedesktop.org Subject: Re: [PATCH i-g-t 2/2] lib/intel_device_info: use dedicated macro for struct pci_id_match init In-Reply-To: <20240902134907.2186238-2-jani.nikula@intel.com> References: <20240902134907.2186238-1-jani.nikula@intel.com> <20240902134907.2186238-2-jani.nikula@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 02 Sep 2024 06:49:07 -0700, Jani Nikula wrote: > > Now that we can pass our own macros to the INTEL_*_IDS() and XE_*_IDS() > macros, define a new macro INTEL_PCI_ID_INIT() for struct pci_id_match > initialization with designated initializers. > > INTEL_VGA_DEVICE() is aimed at initializing kernel struct pci_device_id, > and it's mostly just a coincidence that it can be used to initialize > struct pci_id_match. Indeed, the member names are different, and the IGT > usage has prevented the kernel from switching to designated > initializers. OK, understand what you mean since INTEL_VGA_DEVICE comes from kernel headers. So this is: Reviewed-by: Ashutosh Dixit