From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7000710EA11
 for <igt-dev@lists.freedesktop.org>; Wed,  4 May 2022 04:32:55 +0000 (UTC)
Date: Tue, 03 May 2022 21:32:53 -0700
Message-ID: <8735hprk7e.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
In-Reply-To: <874k26qac3.wl-ashutosh.dixit@intel.com>
References: <20220421170245.11898-1-anshuman.gupta@intel.com>
 <20220421170245.11898-4-anshuman.gupta@intel.com>
 <875ymmqer3.wl-ashutosh.dixit@intel.com>
 <874k26qac3.wl-ashutosh.dixit@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t 3/3] i915_pm_rpm: rpm resume by user
 forcewake
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com,
 Chris Wilson <chris.p.wilson@intel.com>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Tue, 03 May 2022 19:51:24 -0700, Dixit, Ashutosh wrote:
>
> > Change function name to disable_all_screens_and_clr_forcewake_and_wait()
> > (s/or/and/) since we are doing both?
>
> Or we could do this:
>
>	if (data->fw_fd)
>		clear_forcewake(data);
>
> Basically, I think either make both enable and disable functions
> unconditional, or set/clear forcewake in both only for headless (and name
> the functions appropriately).

I think the code will be clearer if we do in only for headless (as is in
the patch) but we could just make the above change in the disable function.