Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 13 Jul 2021 19:56:16 -0700, Srinivas, Vidya wrote:
>
> Hi Ashutosh,
>
> Apologies, yes it should be &&. You are right. How do I fix it, revert and resubmit?
> Patch is merged. Should I submit another patch saying fixes this?
> Immediately it might not be breaking anything huge but I need to fix it.

No need to revert, just send another patch to fix it.

>
> Regards
> Vidya
>
> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: Wednesday, July 14, 2021 7:36 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels
>
> On Thu, 08 Jul 2021 23:57:41 -0700, Vidya Srinivas wrote:
> >
> > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > +     char buf[8192];
> > +     char *str;
> > +     bool ret;
> > +     int debugfs_fd;
> > +     drmModeConnector *c;
> > +     igt_output_t *output = igt_get_single_output_for_pipe(display,
> > +pipe);
> > +
> > +     if (!is_i915_device(display->drm_fd))
> > +             return false;
> > +
> > +     c = output->config.connector;
> > +     if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> > +             c->connector_type != DRM_MODE_CONNECTOR_DSI)
> > +             return false;
>
> Isn't this an && rather than an || ?
>
> [298/1063] Compiling C object 'tests/59830eb@@kms_plane_alpha_blend@exe/kms_plane_alpha_blend.c.o'.
> ../tests/kms_plane_alpha_blend.c: In function ‘is_6bpc’:
> ../tests/kms_plane_alpha_blend.c:457:50: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
>   if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
>                                                   ^~ You cannot merge code with compile warnings.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev