Re: [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 07 Apr 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-04-07 09:42:01)
>> On Tue, 07 Apr 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > Include the reason why we are dumping the task state (test timeout) in
>> > the kmsg log prior to the task state. Hopefully this helps when reading
>> > the dump.
>> >
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: Petri Latvala <petri.latvala@intel.com>
>> > ---
>> >  runner/executor.c | 25 ++++++++++++++++---------
>> >  1 file changed, 16 insertions(+), 9 deletions(-)
>> >
>> > diff --git a/runner/executor.c b/runner/executor.c
>> > index 1b69f9c57..7061b28d3 100644
>> > --- a/runner/executor.c
>> > +++ b/runner/executor.c
>> > @@ -678,9 +678,20 @@ static bool sysrq(char cmd)
>> >       return success;
>> >  }
>> >  
>> > -static void show_kernel_task_state(void)
>> > +static const char *show_kernel_task_state(const char *msg)
>> >  {
>> > +     int fd;
>> > +
>> > +     fd = open("/dev/kmsg", O_WRONLY);
>> > +     if (fd != -1) {
>> > +             write(fd, "<4>[IGT] ", 7);
>> > +             write(fd, msg, strlen(msg));
>> > +             close(fd);
>> > +     }
>> > +
>> 
>> igt_kmsg(KMSG_WARNING "%s\n", msg);
>
> We're outside of libigt.so

Quoting yourself, "Yeah, I haven't had coffee."

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev