Re: [igt-dev] [PATCH i-g-t 2/9] tests/intel_dp_compliance: Skip tests as tiling is not supported

Dixit, Ashutosh
2020-02-04T06:15:44Z

On Mon, 03 Feb 2020 22:00:27 -0800, Ramalingam C wrote:
>
> On 2020-02-03 at 21:55:51 -0800, Dixit, Ashutosh wrote:
> > On Fri, 31 Jan 2020 21:55:05 -0800, Dixit, Ashutosh wrote:
> > >
> > > On Fri, 31 Jan 2020 09:31:02 -0800, Ramalingam C wrote:
> > > >
> > > > Skip the test if the tiling is not supported on the platforms.
> > > >
> > > > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > > > ---
> > > > tools/intel_dp_compliance.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/tools/intel_dp_compliance.c b/tools/intel_dp_compliance.c
> > > > index 5cc3d37a71d6..8f4ea3f3d328 100644
> > > > --- a/tools/intel_dp_compliance.c
> > > > +++ b/tools/intel_dp_compliance.c
> > > > @@ -1043,6 +1043,8 @@ int main(int argc, char **argv)
> > > > drm_fd = drm_open_driver(DRIVER_ANY);
> > > > gen = intel_gen(intel_get_drm_devid(drm_fd));
> > > >
> > > > + /* Set tiling is not supported on newer platforms */
> > > > + gem_require_mappable_ggtt(drm_fd);
> > >
> > > But the test exclusively uses LOCAL_DRM_FORMAT_MOD_NONE? We should see if
> > > it can use device_coherent() or see if we can drop this from this series
> > > for now and revisit later with the other display tests?
> >
> > I think this can just use device_coherent().
> Ashutosh,
>
> Still we have the set_tiling used in this flow. As per our discussion we
> should skip when we try to do legacy tiling. Am I missing something
> here?

Afais set_tiling is not used, only LOCAL_DRM_FORMAT_MOD_NONE is used.