Re: [igt-dev] [PATCH i-g-t 5/9] tests/kms_psr: Skip tests on mmap_gtt, if no mappable aperture

Dixit, Ashutosh
2020-02-09T00:42:00Z

On Mon, 03 Feb 2020 22:38:59 -0800, Dixit, Ashutosh wrote:
>
> On Fri, 31 Jan 2020 09:31:05 -0800, Ramalingam C wrote:
> >
> > Due to non availability of the mappable aperture on discrete GPUs,
> > skip the tests specific to mmap_gtt
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > ---
> > tests/kms_psr.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> > index d9be87d927b2..13ed02f46ac4 100644
> > --- a/tests/kms_psr.c
> > +++ b/tests/kms_psr.c
> > @@ -270,6 +270,7 @@ static void run_test(data_t *data)
> > expected = "GREEN";
> > break;
> > case MMAP_GTT:
> > + gem_require_mappable_ggtt(data->drm_fd);
> > ptr = gem_mmap__gtt(data->drm_fd, handle, data->mod_size,
> > PROT_WRITE);
> > gem_set_domain(data->drm_fd, handle,
>
> This test is actually using tiling (using LOCAL_I915_FORMAT_MOD_X_TILED) so
> probably more than this needs to be skipped?

Sorry, my earlier assessment was incorrect:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>