From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id ACA426E0F9 for ; Mon, 26 Nov 2018 12:09:47 +0000 (UTC) From: Jani Nikula In-Reply-To: <20181126100824.31623-1-daniel.vetter@ffwll.ch> References: <20181126100824.31623-1-daniel.vetter@ffwll.ch> Date: Mon, 26 Nov 2018 14:10:08 +0200 Message-ID: <8736roca5b.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Daniel Vetter , IGT development Cc: Daniel Vetter List-ID: T24gTW9uLCAyNiBOb3YgMjAxOCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4gd3JvdGU6Cj4gU29tZSB0ZXN0cyBhc3N1bWUgdGhhdCBjbG9zZSBvbiBhbiB1bm9wZW5lZCBm ZCBpcyBmaW5lLCBleGNlcHQgaXQncwo+IG5vdCBqdXN0IHVub3BlbmVkIGJ1dCBhY3R1YWxseSBz dGFjayBnYXJiYWdlLiBUaGVyZSdzIGEgZ29vZCBjaGFuY2Ugd2UKPiBlbmQgdXAgcnVubmluZyBj bG9zZSgwKSwgd2hpY2ggd3JlYWtzIHRoZSB0ZXN0Y2FzZSBlbnVtZXJhdGlvbi4gRml4Cj4gdGhp cy4KPgo+IE5vdCBzdXJlIHRoZXJlJ3MgYSBiZXR0ZXIgd2F5IHRvIGNhdGNoIHRoaXMgdGhhbiBn aXQgZ3JlcCBwbHVzIGxvdHMgb2YKPiBtYW51YWwgYXVkaXRpbmcgLi4uIFRoZSB1bml0IHRlc3Rz IG9ubHkgY2F0Y2ggaXQgYnkgYWNjaWRlbnQgKHg4Ngo+IHdvcmtzIGZpbmUsIEkgaGl0IGl0IGlu IG9uZSB0ZXN0Y2FzZSBvbmx5IGNyb3NzLWJ1aWxkaW5nIHRvIGFhcmNoNjQpLgo+Cj4gU2lnbmVk LW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gLS0tCj4g IHRlc3RzL2k5MTUvZ2VtX3ByZWFkX2FmdGVyX2JsaXQuYyAgfCAzICsrLQo+ICB0ZXN0cy9pOTE1 L2dlbV90aWxlZF9mZW5jZV9ibGl0cy5jIHwgMyArKy0KPiAgdGVzdHMvaTkxNS9nZW1fdGlsZWRf c3dhcHBpbmcuYyAgICB8IDMgKystCj4gIDMgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCsp LCAzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2k5MTUvZ2VtX3ByZWFkX2Fm dGVyX2JsaXQuYyBiL3Rlc3RzL2k5MTUvZ2VtX3ByZWFkX2FmdGVyX2JsaXQuYwo+IGluZGV4IDZl ZjNjYTIwMDc3Ni4uY2VlOTIxMjc0OWQ2IDEwMDY0NAo+IC0tLSBhL3Rlc3RzL2k5MTUvZ2VtX3By ZWFkX2FmdGVyX2JsaXQuYwo+ICsrKyBiL3Rlc3RzL2k5MTUvZ2VtX3ByZWFkX2FmdGVyX2JsaXQu Ywo+IEBAIC0yNDgsNSArMjQ4LDYgQEAgaWd0X21haW4KPiAgCQlkcm1faW50ZWxfYnVmbWdyX2Rl c3Ryb3koYnVmbWdyKTsKPiAgCX0KPiAgCj4gLQljbG9zZShmZCk7CgpUaGlzIG9uZSBpc24ndCBz dGFjayBnYXJiYWdlLCBpdCdzIGd1YXJhbnRlZWQgdG8gYmUgMCBmb3IKIWlndF9maXh0dXJlLiBU aGUgb3RoZXIgdHdvIGFyZSBnYXJiYWdlIG9uIHN0YWNrLgoKVGhlIGNoYW5nZSBpcwoKUmV2aWV3 ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgpidXQgcGxlYXNlIHVw ZGF0ZSB0aGUgY29tbWl0IG1lc3NhZ2UuCgo+ICsJaWd0X2ZpeHR1cmUKPiArCQljbG9zZShmZCk7 Cj4gIH0KPiBkaWZmIC0tZ2l0IGEvdGVzdHMvaTkxNS9nZW1fdGlsZWRfZmVuY2VfYmxpdHMuYyBi L3Rlc3RzL2k5MTUvZ2VtX3RpbGVkX2ZlbmNlX2JsaXRzLmMKPiBpbmRleCBjMDJlMzVhNWZlNGMu LjI0NTNiY2MwYjI3MSAxMDA2NDQKPiAtLS0gYS90ZXN0cy9pOTE1L2dlbV90aWxlZF9mZW5jZV9i bGl0cy5jCj4gKysrIGIvdGVzdHMvaTkxNS9nZW1fdGlsZWRfZmVuY2VfYmxpdHMuYwo+IEBAIC0y MzAsNSArMjMwLDYgQEAgaWd0X21haW4KPiAgCQlydW5fdGVzdChmZCwgY291bnQpOwo+ICAJfQo+ ICAKPiAtCWNsb3NlKGZkKTsKPiArCWlndF9maXh0dXJlCj4gKwkJY2xvc2UoZmQpOwo+ICB9Cj4g ZGlmZiAtLWdpdCBhL3Rlc3RzL2k5MTUvZ2VtX3RpbGVkX3N3YXBwaW5nLmMgYi90ZXN0cy9pOTE1 L2dlbV90aWxlZF9zd2FwcGluZy5jCj4gaW5kZXggZGNlNjY4MDYzMDE0Li5kZGYyYTc0OGZjODQg MTAwNjQ0Cj4gLS0tIGEvdGVzdHMvaTkxNS9nZW1fdGlsZWRfc3dhcHBpbmcuYwo+ICsrKyBiL3Rl c3RzL2k5MTUvZ2VtX3RpbGVkX3N3YXBwaW5nLmMKPiBAQCAtMjM1LDUgKzIzNSw2IEBAIGlndF9t YWluCj4gIAkJCXRocmVhZF9maW5pKCZ0aHJlYWRzW25dKTsKPiAgCX0KPiAgCj4gLQljbG9zZShm ZCk7Cj4gKwlpZ3RfZml4dHVyZQo+ICsJCWNsb3NlKGZkKTsKPiAgfQoKLS0gCkphbmkgTmlrdWxh LCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pZ3QtZGV2Cg==