From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Scott D Phillips In-Reply-To: References: <20180409163539.13980-1-tvrtko.ursulin@linux.intel.com> <87fu441fdl.fsf@intel.com> Date: Tue, 10 Apr 2018 07:57:19 -0700 Message-ID: <8737039kj4.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] tools/aubdump: Fix ISO C90 forbids mixed declarations and code warning List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin , Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-ID: VHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNvbT4gd3JpdGVzOgoK PiBPbiAwOS8wNC8yMDE4IDE4OjAzLCBTY290dCBEIFBoaWxsaXBzIHdyb3RlOgo+PiBUdnJ0a28g VXJzdWxpbiA8dHVyc3VsaW5AdXJzdWxpbi5uZXQ+IHdyaXRlczoKPj4gCj4+PiBGcm9tOiBUdnJ0 a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pj4KPj4+IEJhY2sgdG8gYSBj bGVhbiBidWlsZCB3aXRoIG5vIHdhcm5pbmdzLCBhdCBsZWFzdCBmb3IgbWUuCj4+IAo+PiBXaHkg YzkwPyBJZiB0aGF0J3MgdGhlIGxhbmd1YWdlIHdlIG1lYW4gdG8gdGFyZ2V0IHRoZW4gd2Ugc2hv dWxkCj4+IHByb2JhYmx5IGFkZCBpdCB0byB0aGUgYnVpbGQgc3lzdGVtIHNvIHBlb3BsZSB3aXRo IGdjYyA1LjEgYW5kIGxhdGVyCj4+IHdpbGwgc2VlIHRoZSB3YXJuaW5ncyB0b28uIGZ3aXcsIG15 IGJ1aWxkIHdpdGggY2xhbmcgNiBnaXZlcyBhIGNvdXBsZQo+PiBkb3plbiB3YXJuaW5ncy4KPgo+ IEkgYW0gYnVpbGRpbmcgdW5kZXIgVWJ1bnR1IDE3LjEwIHdpdGggR0NDIDcuMi4wLiBOb3JtYWwg Y29uZmlndXJlICYmIAo+IG1ha2UsIGFuZCBnZXQgdGhpcyB3YXJuaW5nLiBBbmQgc2luY2UgSSBj YW4ndCBzcG90IHRoYXQgSUdUIGlzIHNldHRpbmcgCj4gdGhlIEMgc3RhbmRhcmQgZXhwbGljaXRs eSwgSSBndWVzcyB0aGF0J3MgdGhlIGRlZmF1bHQuCgpBaCwgdHVybnMgb3V0IGl0J3Mgbm90IC1z dGQ9YzkwLCBidXQgYW4gZXhwbGljaXQKLVdkZWNsYXJhdGlvbi1hZnRlci1zdGF0ZW1lbnQgdGhh dCB3ZSBwaWNrIHVwIHRocm91Z2gKWE9SR19ERUZBVUxUX09QVElPTlMuIENsYW5nIHNlZW1zIHRv IGVtaXQgdGhhdCB3YXJuaW5nIG9ubHkgaWYgaXQncyBpbgpjOTAgbW9kZSwgd2hpY2ggaXMgd2h5 IEkgZGlkbid0IHNlZSBpdC4gU28gSSdsbCBzYXkKClJldmlld2VkLWJ5OiBTY290dCBEIFBoaWxs aXBzIDxzY290dC5kLnBoaWxsaXBzQGludGVsLmNvbT4KCj4gVGhpcyBvbmUgaXMgdGhlIG9ubHkg d2FybmluZyBvbiBteSBidWlsZCBidHcuCj4KPiBSZWdhcmRzLAo+Cj4gVHZydGtvCj4KPj4+IFNp Z25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+ PiBDYzogSm9yZGFuIEp1c3RlbiA8am9yZGFuLmwuanVzdGVuQGludGVsLmNvbT4KPj4+IENjOiBT Y290dCBEIFBoaWxsaXBzIDxzY290dC5kLnBoaWxsaXBzQGludGVsLmNvbT4KPj4+IC0tLQo+Pj4g ICB0b29scy9hdWJkdW1wLmMgfCA3ICsrKystLS0KPj4+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvYXVi ZHVtcC5jIGIvdG9vbHMvYXViZHVtcC5jCj4+PiBpbmRleCAyNjcwNjFiMGZjMmIuLjJkMmI2YzYw N2E0MyAxMDA2NDQKPj4+IC0tLSBhL3Rvb2xzL2F1YmR1bXAuYwo+Pj4gKysrIGIvdG9vbHMvYXVi ZHVtcC5jCj4+PiBAQCAtMzk0LDEwICszOTQsMTEgQEAgZ2VuOF9lbWl0X2dndHRfcHRlX2Zvcl9y YW5nZSh1aW50NjRfdCBzdGFydCwgdWludDY0X3QgZW5kKQo+Pj4gICAKPj4+ICAgCWVudHJ5X2Fk ZHIgPSBzdGFydCAmIH4oNDA5NiAtIDEpOwo+Pj4gICAJZG8gewo+Pj4gKwkJdWludDY0X3QgbGFz dF9wYWdlX2VudHJ5LCBudW1fZW50cmllczsKPj4+ICsKPj4+ICAgCQlwYWdlX251bSA9IGVudHJ5 X2FkZHIgPj4gMjE7Cj4+PiAtCQl1aW50NjRfdCBsYXN0X3BhZ2VfZW50cnkgPQo+Pj4gLQkJCW1p bigocGFnZV9udW0gKyAxKSA8PCAyMSwgZW5kX2FsaWduZWQpOwo+Pj4gLQkJdWludDY0X3QgbnVt X2VudHJpZXMgPSAobGFzdF9wYWdlX2VudHJ5IC0gZW50cnlfYWRkcikgPj4gMTI7Cj4+PiArCQls YXN0X3BhZ2VfZW50cnkgPSBtaW4oKHBhZ2VfbnVtICsgMSkgPDwgMjEsIGVuZF9hbGlnbmVkKTsK Pj4+ICsJCW51bV9lbnRyaWVzID0gKGxhc3RfcGFnZV9lbnRyeSAtIGVudHJ5X2FkZHIpID4+IDEy Owo+Pj4gICAJCW1lbV90cmFjZV9tZW1vcnlfd3JpdGVfaGVhZGVyX291dCgKPj4+ICAgCQkJZW50 cnlfYWRkciA+PiA5LCBudW1fZW50cmllcyAqIEdFTjhfUFRFX1NJWkUsCj4+PiAgIAkJCUFVQl9N RU1fVFJBQ0VfTUVNT1JZX0FERFJFU1NfU1BBQ0VfR0dUVF9FTlRSWSk7Cj4+PiAtLSAKPj4+IDIu MTQuMQo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ PiBpZ3QtZGV2IG1haWxpbmcgbGlzdAo+PiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK Pj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1k ZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=