From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77D87C30653 for ; Sun, 30 Jun 2024 23:00:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D41610E0D7; Sun, 30 Jun 2024 23:00:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BrDpLn/I"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C3A210E0D7 for ; Sun, 30 Jun 2024 23:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719788407; x=1751324407; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=xiddbXJfQpubreym9d61e0xT+tIe+lkO04pjoiWdIOk=; b=BrDpLn/Ish3TK5E1iKc1Dt3XrQIGlCjGGYajDw7SLNNl9sXS3R/7m8ZL OBlsu6lvMryJoKaDpLnSSAZs5B344B72MsF0pQoOSTwiR1R5alq6+Z1SA jzV/ann1Y5ZJ+FNfnHjTGka5QbGqlDRk7T6WLZEbczqbS/F11ZqyJh3ZA NCYrN044BLz4F3+urDKxRlD65nmdq6aknzGhdZLjVmaVyuOYCWIhoIGdH FDl5V/Fbo4wWidb9gMssDBU/98Pxw7WXUV6krDEyz3MpTjSBJHb+FMXTF bl3BuqxdlNt1nNO5CuyDSLitfyvoCYhp8ylnaWIgezchU6q6VvBeV2SdG A==; X-CSE-ConnectionGUID: MH8c/mGxTdGPMr62kL0rWg== X-CSE-MsgGUID: ZYZvLzmJSnGsEposq97+rg== X-IronPort-AV: E=McAfee;i="6700,10204,11119"; a="28292847" X-IronPort-AV: E=Sophos;i="6.09,175,1716274800"; d="scan'208";a="28292847" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2024 16:00:06 -0700 X-CSE-ConnectionGUID: kyxG1F+TQum6+7IeBC9rng== X-CSE-MsgGUID: gdUrOtQ1R3usjs9DqZcWlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,175,1716274800"; d="scan'208";a="45993689" Received: from lmeganx-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.32.7]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2024 16:00:07 -0700 Date: Sun, 30 Jun 2024 15:43:11 -0700 Message-ID: <874j9aaw74.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: igt-dev@lists.freedesktop.org Subject: Re: [PATCH i-g-t 13/28] tests/intel/xe_oa: Add oa exponent tests In-Reply-To: References: <20240620200054.3550653-1-ashutosh.dixit@intel.com> <20240620200054.3550653-14-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Thu, 20 Jun 2024 16:18:30 -0700, Umesh Nerlige Ramappa wrote: > > On Thu, Jun 20, 2024 at 01:00:38PM -0700, Ashutosh Dixit wrote: > > Add "invalid-oa-exponent" and "oa-exponents". > > > > Signed-off-by: Ashutosh Dixit > > one nit. with or without > > Reviewed-by: Umesh Nerlige Ramappa Thanks. > > +static bool expected_report_timing_delta(uint32_t delta, uint32_t expected_delta) > > +{ > > + /* > > + * On ICL, the OA unit appears to be a bit more relaxed about > > + * its timing for emitting OA reports (often missing the > > + * deadline by 1 timestamp). > > + */ > > + if (IS_ICELAKE(devid)) > > + return delta <= (expected_delta + 3); > > + else > > can drop ICL stuff Done. Thanks. -- Ashutosh